Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 194713007: TimelinePanel: restore selectedRecord behevior by removing windowFilter. (Closed)

Created:
6 years, 9 months ago by loislo
Modified:
6 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

TimelinePanel: restore selectedRecord behevior by removing windowFilter. BUG= R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -53 lines) Patch
M LayoutTests/inspector/timeline/timeline-window-filter.html View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/FlameChart.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/TimelinePanel.js View 4 chunks +0 lines, -40 lines 0 comments Download
M Source/devtools/front_end/TimelinePresentationModel.js View 3 chunks +23 lines, -9 lines 0 comments Download
M Source/devtools/front_end/TimelineView.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
loislo
with fixed test
6 years, 9 months ago (2014-03-11 12:34:48 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-03-11 12:36:09 UTC) #2
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 9 months ago (2014-03-11 12:48:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/194713007/1
6 years, 9 months ago (2014-03-11 12:48:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 13:45:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-11 13:45:58 UTC) #6
loislo
6 years, 9 months ago (2014-03-11 15:08:43 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 manually as r168926 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698