Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1781)

Unified Diff: Source/devtools/front_end/TimelinePanel.js

Issue 194713007: TimelinePanel: restore selectedRecord behevior by removing windowFilter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/FlameChart.js ('k') | Source/devtools/front_end/TimelinePresentationModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelinePanel.js
diff --git a/Source/devtools/front_end/TimelinePanel.js b/Source/devtools/front_end/TimelinePanel.js
index 073dfa333cd76a7d94cf1dadebd8eb69f40c8d39..57716dd5cc2a7b1be4aa0c9c4b4fe8d35c923c34 100644
--- a/Source/devtools/front_end/TimelinePanel.js
+++ b/Source/devtools/front_end/TimelinePanel.js
@@ -68,13 +68,11 @@ WebInspector.TimelinePanel = function()
this._model.addEventListener(WebInspector.TimelineModel.Events.RecordFilterChanged, this._refreshViews, this);
this._model.addEventListener(WebInspector.TimelineModel.Events.RecordAdded, this._onRecordAdded, this);
- this._windowFilter = new WebInspector.TimelineWindowFilter();
this._categoryFilter = new WebInspector.TimelineCategoryFilter();
this._durationFilter = new WebInspector.TimelineIsLongFilter();
this._textFilter = new WebInspector.TimelineTextFilter();
this._model.addFilter(new WebInspector.TimelineHiddenFilter());
- this._model.addFilter(this._windowFilter);
this._model.addFilter(this._categoryFilter);
this._model.addFilter(this._durationFilter);
this._model.addFilter(this._textFilter);
@@ -205,7 +203,6 @@ WebInspector.TimelinePanel.prototype = {
{
this._windowStartTime = event.data.startTime;
this._windowEndTime = event.data.endTime;
- this._windowFilter.setWindowTimes(this._windowStartTime, this._windowEndTime);
for (var i = 0; i < this._currentViews.length; ++i)
this._currentViews[i].setWindowTimes(this._windowStartTime, this._windowEndTime);
@@ -588,7 +585,6 @@ WebInspector.TimelinePanel.prototype = {
_onRecordsCleared: function()
{
this.requestWindowTimes(0, Infinity);
- this._windowFilter._reset();
delete this._selectedRecord;
if (this._lazyFrameModel)
this._lazyFrameModel.reset();
@@ -1085,42 +1081,6 @@ WebInspector.TimelineTextFilter.prototype = {
* @constructor
* @extends {WebInspector.TimelineModel.Filter}
*/
-WebInspector.TimelineWindowFilter = function()
-{
- WebInspector.TimelineModel.Filter.call(this);
- this._reset();
-}
-
-WebInspector.TimelineWindowFilter.prototype = {
- _reset: function()
- {
- this._windowStartTime = 0;
- this._windowEndTime = Infinity;
- },
-
- setWindowTimes: function(windowStartTime, windowEndTime)
- {
- this._windowStartTime = windowStartTime;
- this._windowEndTime = windowEndTime;
- this.notifyFilterChanged();
- },
-
- /**
- * @param {!WebInspector.TimelineModel.Record} record
- * @return {boolean}
- */
- accept: function(record)
- {
- return record.lastChildEndTime >= this._windowStartTime && record.startTime <= this._windowEndTime;
- },
-
- __proto__: WebInspector.TimelineModel.Filter.prototype
-}
-
-/**
- * @constructor
- * @extends {WebInspector.TimelineModel.Filter}
- */
WebInspector.TimelineHiddenFilter = function()
{
WebInspector.TimelineModel.Filter.call(this);
« no previous file with comments | « Source/devtools/front_end/FlameChart.js ('k') | Source/devtools/front_end/TimelinePresentationModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698