third_party/WebKit/Source/core/html/track/VideoTrack.h - Issue 1947033002: Change "invalid value default" for HTMLTrackElement 'kind' to "metadata"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/VideoTrack.h

Issue 1947033002: Change "invalid value default" for HTMLTrackElement 'kind' to "metadata" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/track/TrackBase.cpp ('k') | third_party/WebKit/Source/core/html/track/VideoTrack.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/VideoTrack.h

diff --git a/third_party/WebKit/Source/core/html/track/VideoTrack.h b/third_party/WebKit/Source/core/html/track/VideoTrack.h

index a6dc1e9d9bb2ee789d62033ff2e05e2e85d7329d..4040120a27393063ba590c6503c2ac5bd850d71d 100644

--- a/third_party/WebKit/Source/core/html/track/VideoTrack.h

+++ b/third_party/WebKit/Source/core/html/track/VideoTrack.h

@@ -45,7 +45,7 @@ private:

// TrackBase

bool isValidKind(const AtomicString& kind) const override { return isValidKindKeyword(kind); }

- AtomicString defaultKind() const override;

+ AtomicString invalidValueDefaultKind() const override;

bool m_selected;

};