third_party/WebKit/Source/core/html/track/TrackBase.cpp - Issue 1947033002: Change "invalid value default" for HTMLTrackElement 'kind' to "metadata"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/TrackBase.cpp

Issue 1947033002: Change "invalid value default" for HTMLTrackElement 'kind' to "metadata" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/track/TrackBase.h ('k') | third_party/WebKit/Source/core/html/track/VideoTrack.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/TrackBase.cpp

diff --git a/third_party/WebKit/Source/core/html/track/TrackBase.cpp b/third_party/WebKit/Source/core/html/track/TrackBase.cpp

index 7a2ce55fa026ddc301fbf6fb23d51cacb10cb375..dd216230a755b167d8273ec19222e6161e09fddf 100644

--- a/third_party/WebKit/Source/core/html/track/TrackBase.cpp

+++ b/third_party/WebKit/Source/core/html/track/TrackBase.cpp

@@ -70,7 +70,7 @@ void TrackBase::setKind(const AtomicString& kind)

if (isValidKind(kind))

m_kind = kind;

else

- m_kind = defaultKind();

+ m_kind = invalidValueDefaultKind();

}

} // namespace blink

« no previous file with comments | « third_party/WebKit/Source/core/html/track/TrackBase.h ('k') | third_party/WebKit/Source/core/html/track/VideoTrack.h » ('j') | no next file with comments »