third_party/WebKit/Source/core/html/HTMLTrackElement.cpp - Issue 1947033002: Change "invalid value default" for HTMLTrackElement 'kind' to "metadata"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTrackElement.cpp

Issue 1947033002: Change "invalid value default" for HTMLTrackElement 'kind' to "metadata" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-kind.html ('k') | third_party/WebKit/Source/core/html/track/AudioTrack.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTrackElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTrackElement.cpp b/third_party/WebKit/Source/core/html/HTMLTrackElement.cpp

index e51919a8b1b8a36f673e34231a816f0fea93954d..d9a9108db84e47dbe6ea33b0f85e5cc76b3d113c 100644

--- a/third_party/WebKit/Source/core/html/HTMLTrackElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTrackElement.cpp

@@ -94,7 +94,7 @@ void HTMLTrackElement::parseAttribute(const QualifiedName& name, const AtomicStr

// 4.8.10.12.3 Sourcing out-of-band text tracks

// As the kind, label, and srclang attributes are set, changed, or removed, the text track must update accordingly...

} else if (name == kindAttr) {

- track()->setKind(value.lower());

+ track()->setKind(!value.isNull() ? value.lower() : TextTrack::subtitlesKeyword());

} else if (name == labelAttr) {

track()->setLabel(value);

} else if (name == srclangAttr) {