third_party/WebKit/LayoutTests/media/track/track-kind.html - Issue 1947033002: Change "invalid value default" for HTMLTrackElement 'kind' to "metadata"

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-kind.html

Issue 1947033002: Change "invalid value default" for HTMLTrackElement 'kind' to "metadata" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/opera/interfaces/TextTrack/kind.html ('k') | third_party/WebKit/Source/core/html/HTMLTrackElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/track/track-kind.html

diff --git a/third_party/WebKit/LayoutTests/media/track/track-kind.html b/third_party/WebKit/LayoutTests/media/track/track-kind.html

index bf436cc8815dacb167e8ba3177295eb81a9ec77f..bdd2ad5f2f02d4a79429c8fb1ee8a1f54278ab16 100644

--- a/third_party/WebKit/LayoutTests/media/track/track-kind.html

+++ b/third_party/WebKit/LayoutTests/media/track/track-kind.html

@@ -1,5 +1,5 @@

<!DOCTYPE html>

-<title>Tests that the "kind" attribute is set properly and that cues are only visible when "kind" is set to "captions" or "subtitles".</title>

+<title>Tests that the "kind" attribute is set properly</title>

<video>

</video>

@@ -28,38 +28,34 @@ async_test(function(t) {

assert_equals(trackElement.kind, "subtitles");

assert_equals(video.textTracks[0].kind, "subtitles");

- // Set to bogus value, should return default.

+ // Set to bogus value, should return invalid value default.

// Set via DOM.

var value = "english-metadata"

trackElement.removeAttribute("kind");

trackElement.kind = value;

assert_equals(trackElement.getAttribute("kind"), value);

- assert_equals(trackElement.kind, "subtitles");

- assert_equals(trackElement.track.kind, "subtitles");

+ assert_equals(trackElement.kind, "metadata");

+ assert_equals(trackElement.track.kind, "metadata");

// Set via attribute.

trackElement.removeAttribute("kind");

trackElement.setAttribute("kind", value);

- assert_equals(trackElement.kind, "subtitles");

- assert_equals(trackElement.track.kind, "subtitles");

assert_equals(trackElement.getAttribute("kind"), value);

+ assert_equals(trackElement.kind, "metadata");

+ assert_equals(trackElement.track.kind, "metadata");

// Set to known values.

- setKindAndCheck("subtitles", true);

- setKindAndCheck("captions", true);

- setKindAndCheck("descriptions", false);

- setKindAndCheck("chapters", false);

- setKindAndCheck("metadata", false);

+ setKindAndCheck("subtitles");

+ setKindAndCheck("captions");

+ setKindAndCheck("descriptions");

+ setKindAndCheck("chapters");

+ setKindAndCheck("metadata");

t.done();

}

- function setKindAndCheck(value, cueIsVisible) {

+ function setKindAndCheck(value) {

// set via DOM.

trackElement.removeAttribute("kind");

trackElement.kind = value;

@@ -72,14 +68,6 @@ async_test(function(t) {

assert_equals(trackElement.kind, value);

assert_equals(trackElement.track.kind, value);

assert_equals(trackElement.getAttribute("kind"), value);

- if (cueIsVisible) {

- assert_equals(textTrackDisplayElement(video, "display").innerText, "Lorem ipsum dolor sit amet, ");

- } else {

- assert_throws(null, function() {

- textTrackDisplayElement(video, "display");

- });

- }

}

});

-</script>

+</script>