Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1946763002: EDK: Add MojoHandleRights to DispatcherTransport. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work788_edk_handle_10
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Add MojoHandleRights to DispatcherTransport. This requires that the things that create |DispatcherTransport|s also deal in |Handle|s. I'll rename DispatcherTransport to HandleTransport separately, since this change is already rather big. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ef6c996ac16a9a8f1e70a516b7686f93ad8d882d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -134 lines) Patch
M mojo/edk/system/data_pipe_impl_unittest.cc View 6 chunks +53 lines, -41 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 3 chunks +4 lines, -3 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M mojo/edk/system/handle.h View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/handle_table.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/edk/system/handle_transport.h View 2 chunks +15 lines, -9 lines 0 comments Download
M mojo/edk/system/ipc_support_unittest.cc View 5 chunks +10 lines, -3 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 6 chunks +18 lines, -13 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher_unittest.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 10 chunks +25 lines, -15 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 19 chunks +52 lines, -37 lines 0 comments Download

Depends on Patchset:

Issue 1942423002 Patch 20001

Dependent Patchsets:

Issue 1947733002 Patch 1

Messages

Total messages: 4 (1 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/1942423002/.)
4 years, 7 months ago (2016-05-03 20:48:01 UTC) #1
azani
lgtm
4 years, 7 months ago (2016-05-03 23:12:01 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-04 02:14:31 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ef6c996ac16a9a8f1e70a516b7686f93ad8d882d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698