Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8687)

Unified Diff: components/password_manager/content/browser/credential_manager_impl.cc

Issue 1946563003: Fix blacklisting password forms with Credential Manager API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ios Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/content/browser/credential_manager_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/content/browser/credential_manager_impl.cc
diff --git a/components/password_manager/content/browser/credential_manager_impl.cc b/components/password_manager/content/browser/credential_manager_impl.cc
index 0d5fa0d157a4a922783cee439c3e69248f53a4c9..c69d46aa95757080578b4a3e9647e35ff4648e41 100644
--- a/components/password_manager/content/browser/credential_manager_impl.cc
+++ b/components/password_manager/content/browser/credential_manager_impl.cc
@@ -61,13 +61,14 @@ void CredentialManagerImpl::Store(mojom::CredentialInfoPtr credential,
if (!client_->IsSavingAndFillingEnabledForCurrentPage())
return;
+ GURL origin = web_contents()->GetLastCommittedURL().GetOrigin();
std::unique_ptr<autofill::PasswordForm> form(
- CreatePasswordFormFromCredentialInfo(
- info, web_contents()->GetLastCommittedURL().GetOrigin()));
+ CreatePasswordFormFromCredentialInfo(info, origin));
form->skip_zero_click = !IsZeroClickAllowed();
form_manager_.reset(new CredentialManagerPasswordFormManager(
- client_, GetDriver(), *form, this));
+ client_, GetDriver(), *CreateObservedPasswordFormFromOrigin(origin),
+ std::move(form), this));
}
void CredentialManagerImpl::OnProvisionalSaveComplete() {
« no previous file with comments | « no previous file | components/password_manager/content/browser/credential_manager_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698