Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2623)

Unified Diff: appengine/findit/model/crash/test/fracas_crash_analysis_test.py

Issue 1946513003: [Findit] Modify the handler for fracas input message. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Address comment. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/crash/test/fracas_crash_analysis_test.py
diff --git a/appengine/findit/model/crash/test/fracas_crash_analysis_test.py b/appengine/findit/model/crash/test/fracas_crash_analysis_test.py
index aec9f101217be419544aff3b23f9f08c32116d77..248ff4fe45c294493bc5a59364ae831d58246760 100644
--- a/appengine/findit/model/crash/test/fracas_crash_analysis_test.py
+++ b/appengine/findit/model/crash/test/fracas_crash_analysis_test.py
@@ -11,18 +11,25 @@ from model.crash.fracas_crash_analysis import FracasCrashAnalysis
class FracasCrashAnalysisTest(CrashTestCase):
- def testComputedProperties(self):
- channel = 'canary'
- platform = 'win'
- signature = 'signature/here'
- FracasCrashAnalysis.Create(channel, platform, signature).put()
- analysis = FracasCrashAnalysis.Get(channel, platform, signature)
- self.assertEqual(channel, analysis.channel)
- self.assertEqual(platform, analysis.platform)
- self.assertEqual(signature, analysis.signature)
+
+ def testDoNotUseIdentifiersToSetProperties(self):
+ crash_identifiers = {
+ 'chrome_version': '1',
+ 'signature': 'signature/here',
+ 'channel': 'canary',
+ 'platform': 'win',
+ 'process_type': 'browser',
+ }
+ FracasCrashAnalysis.Create(crash_identifiers).put()
+ analysis = FracasCrashAnalysis.Get(crash_identifiers)
+ self.assertIsNone(analysis.crashed_version)
+ self.assertIsNone(analysis.signature)
+ self.assertIsNone(analysis.channel)
+ self.assertIsNone(analysis.platform)
def testFracasCrashAnalysisReset(self):
analysis = FracasCrashAnalysis()
- analysis.versions_to_cpm = {}
+ analysis.historic_metadata = {}
analysis.Reset()
- self.assertIsNone(analysis.versions_to_cpm)
+ self.assertIsNone(analysis.channel)
+ self.assertIsNone(analysis.historic_metadata)

Powered by Google App Engine
This is Rietveld 408576698