Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Side by Side Diff: appengine/findit/model/crash/test/fracas_crash_analysis_test.py

Issue 1946513003: [Findit] Modify the handler for fracas input message. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Address comment. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from datetime import datetime 5 from datetime import datetime
6 6
7 from crash.test.crash_testcase import CrashTestCase 7 from crash.test.crash_testcase import CrashTestCase
8 from model import analysis_status 8 from model import analysis_status
9 from model import result_status 9 from model import result_status
10 from model.crash.fracas_crash_analysis import FracasCrashAnalysis 10 from model.crash.fracas_crash_analysis import FracasCrashAnalysis
11 11
12 12
13 class FracasCrashAnalysisTest(CrashTestCase): 13 class FracasCrashAnalysisTest(CrashTestCase):
14 def testComputedProperties(self): 14
15 channel = 'canary' 15 def testDoNotUseIdentifiersToSetProperties(self):
16 platform = 'win' 16 crash_identifiers = {
17 signature = 'signature/here' 17 'chrome_version': '1',
18 FracasCrashAnalysis.Create(channel, platform, signature).put() 18 'signature': 'signature/here',
19 analysis = FracasCrashAnalysis.Get(channel, platform, signature) 19 'channel': 'canary',
20 self.assertEqual(channel, analysis.channel) 20 'platform': 'win',
21 self.assertEqual(platform, analysis.platform) 21 'process_type': 'browser',
22 self.assertEqual(signature, analysis.signature) 22 }
23 FracasCrashAnalysis.Create(crash_identifiers).put()
24 analysis = FracasCrashAnalysis.Get(crash_identifiers)
25 self.assertIsNone(analysis.crashed_version)
26 self.assertIsNone(analysis.signature)
27 self.assertIsNone(analysis.channel)
28 self.assertIsNone(analysis.platform)
23 29
24 def testFracasCrashAnalysisReset(self): 30 def testFracasCrashAnalysisReset(self):
25 analysis = FracasCrashAnalysis() 31 analysis = FracasCrashAnalysis()
26 analysis.versions_to_cpm = {} 32 analysis.historic_metadata = {}
27 analysis.Reset() 33 analysis.Reset()
28 self.assertIsNone(analysis.versions_to_cpm) 34 self.assertIsNone(analysis.channel)
35 self.assertIsNone(analysis.historic_metadata)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698