Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1946493003: MD History: Remove spinner from the botttom of history-list (Closed)

Created:
4 years, 7 months ago by tsergeant
Modified:
4 years, 7 months ago
Reviewers:
calamity
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, lshang
Base URL:
https://chromium.googlesource.com/chromium/src.git@pseudomaster
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Remove spinner from the botttom of history-list On the advice of UI, we are removing this spinner for the moment. Depending on load speed in the wild, we may investigate adding a loading message back in a way which doesn't overlay the content. The spinner next to the search field is unchanged. BUG=595588 Committed: https://crrev.com/dcc7b70947e4bb31adeab5d3e0f18564851eac21 Cr-Commit-Position: refs/heads/master@{#391379}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M chrome/browser/resources/md_history/history_list.html View 3 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tsergeant
4 years, 7 months ago (2016-05-03 17:33:13 UTC) #3
calamity
lgtm
4 years, 7 months ago (2016-05-03 22:14:58 UTC) #4
tsergeant
+lshang@ for FYI
4 years, 7 months ago (2016-05-03 22:24:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946493003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946493003/20001
4 years, 7 months ago (2016-05-03 22:24:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-03 22:28:56 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 22:30:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dcc7b70947e4bb31adeab5d3e0f18564851eac21
Cr-Commit-Position: refs/heads/master@{#391379}

Powered by Google App Engine
This is Rietveld 408576698