Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2046)

Side by Side Diff: chrome/browser/resources/md_history/history_list.html

Issue 1946493003: MD History: Remove spinner from the botttom of history-list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pseudomaster
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spi nner.html">
5 <link rel="import" href="chrome://resources/cr_elements/cr_shared_menu/cr_shared _menu.html"> 4 <link rel="import" href="chrome://resources/cr_elements/cr_shared_menu/cr_shared _menu.html">
6 <link rel="import" href="chrome://history/constants.html"> 5 <link rel="import" href="chrome://history/constants.html">
7 <link rel="import" href="chrome://history/history_item.html"> 6 <link rel="import" href="chrome://history/history_item.html">
8 <link rel="import" href="chrome://history/shared_style.html"> 7 <link rel="import" href="chrome://history/shared_style.html">
9 8
10 <dom-module id="history-list"> 9 <dom-module id="history-list">
11 <template> 10 <template>
12 <style include="shared-style"> 11 <style include="shared-style">
13 :host { 12 :host {
14 display: flex; 13 display: flex;
15 flex-direction: column; 14 flex-direction: column;
16 position: relative; 15 position: relative;
17 } 16 }
18 17
19 #infinite-list { 18 #infinite-list {
20 flex: 1; 19 flex: 1;
21 padding-top: var(--first-card-padding-top); 20 padding-top: var(--first-card-padding-top);
22 } 21 }
23 22
24 #loading-spinner {
25 bottom: 20px;
26 left: 0;
27 margin: 0 auto;
28 position: absolute;
29 right: 0;
30 width: 28px;
31 }
32
33 paper-item { 23 paper-item {
34 -webkit-user-select: none; 24 -webkit-user-select: none;
35 cursor: pointer; 25 cursor: pointer;
36 font: inherit; 26 font: inherit;
37 } 27 }
38 28
39 paper-item:hover { 29 paper-item:hover {
40 background: #eaeaea; 30 background: #eaeaea;
41 } 31 }
42 </style> 32 </style>
43 <div id="no-results" class="centered-message" 33 <div id="no-results" class="centered-message"
44 hidden$="{{hasResults(historyData.length)}}"> 34 hidden$="{{hasResults(historyData.length)}}">
45 {{noResultsMessage_(searchTerm, loading_)}} 35 {{noResultsMessage_(searchTerm, loading_)}}
46 </div> 36 </div>
47 <iron-list items="{{historyData}}" as="item" id="infinite-list" 37 <iron-list items="{{historyData}}" as="item" id="infinite-list"
48 on-scroll="scrollHandler_" 38 on-scroll="scrollHandler_"
49 hidden$="{{!hasResults(historyData.length)}}"> 39 hidden$="{{!hasResults(historyData.length)}}">
50 <template> 40 <template>
51 <history-item item="[[item]]" 41 <history-item item="[[item]]"
52 starred="[[item.starred]]" 42 starred="[[item.starred]]"
53 selected="{{item.selected}}" 43 selected="{{item.selected}}"
54 is-card-start="[[isCardStart_(item, index, historyData.length)]]" 44 is-card-start="[[isCardStart_(item, index, historyData.length)]]"
55 is-card-end="[[isCardEnd_(item, index, historyData.length)]]" 45 is-card-end="[[isCardEnd_(item, index, historyData.length)]]"
56 has-time-gap="[[needsTimeGap_(item, index, historyData.length)]]" 46 has-time-gap="[[needsTimeGap_(item, index, historyData.length)]]"
57 search-term="[[searchTerm]]" 47 search-term="[[searchTerm]]"
58 number-of-items="[[historyData.length]]"> 48 number-of-items="[[historyData.length]]">
59 </history-item> 49 </history-item>
60 </template> 50 </template>
61 </iron-list> 51 </iron-list>
62 <paper-spinner id="loading-spinner" alt="$i18n{loading}"
63 active="[[loading_]]">
64 </paper-spinner>
65 <cr-shared-menu id="sharedMenu"> 52 <cr-shared-menu id="sharedMenu">
66 <paper-item id="menuMoreButton" on-tap="onMoreFromSiteTap_"> 53 <paper-item id="menuMoreButton" on-tap="onMoreFromSiteTap_">
67 $i18n{moreFromSite} 54 $i18n{moreFromSite}
68 </paper-item> 55 </paper-item>
69 <paper-item id="menuRemoveButton" on-tap="onRemoveFromHistoryTap_"> 56 <paper-item id="menuRemoveButton" on-tap="onRemoveFromHistoryTap_">
70 $i18n{removeFromHistory} 57 $i18n{removeFromHistory}
71 </paper-item> 58 </paper-item>
72 </cr-shared-menu> 59 </cr-shared-menu>
73 </template> 60 </template>
74 <script src="chrome://history/history_list.js"></script> 61 <script src="chrome://history/history_list.js"></script>
75 </dom-module> 62 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698