Issue 1946473003: Set ARM/MIPS configuration for both host and target if needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1946473003: Set ARM/MIPS configuration for both host and target if needed (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
4 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Set ARM/MIPS configuration for both host and target if needed Also, the config should check whether the target is android, not whether the current toolchain is android BUG=607461 R=brettw@chromium.org Review-Url: https://codereview.chromium.org/1934713002 Cr-Commit-Position: refs/heads/master@{#390735} (cherry picked from commit 52b20a0b0c441cd686e8273550e2d5da149db811) Committed: https://chromium.googlesource.com/chromium/src/+/35ff2d81d48334142d8a04a466c52cae5c37195a

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	build/config/arm.gni	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	build/config/mips.gni	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (1 generated)

jochen (gone - plz use gerrit)

Committed patchset #1 (id:1) manually as 35ff2d81d48334142d8a04a466c52cae5c37195a.

4 years, 7 months ago (2016-05-03 08:47:53 UTC) #2

Message was sent while issue was closed.

lgtm