Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1934713002: Set ARM/MIPS configuration for both host and target if needed (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set ARM/MIPS configuration for both host and target if needed Also, the config should check whether the target is android, not whether the current toolchain is android BUG=607461 R=brettw@chromium.org Committed: https://crrev.com/52b20a0b0c441cd686e8273550e2d5da149db811 Cr-Commit-Position: refs/heads/master@{#390735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M build/config/arm.gni View 3 chunks +3 lines, -3 lines 0 comments Download
M build/config/mips.gni View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 7 months ago (2016-04-29 19:06:29 UTC) #1
brettw
lgtm
4 years, 7 months ago (2016-04-29 19:10:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934713002/1
4 years, 7 months ago (2016-04-29 19:11:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 20:16:44 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:28:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52b20a0b0c441cd686e8273550e2d5da149db811
Cr-Commit-Position: refs/heads/master@{#390735}

Powered by Google App Engine
This is Rietveld 408576698