Windows GN clobber error fixes

Windows GN clobber error fixes

The change http://crrev.com/1943583002/ introduced a new check for clobbering on forward_variables_from. This patch fixes the associated errors for the Windows build.

Committed: https://crrev.com/3003018ab361c53988d66b80dbed84c76def5c3d
Cr-Commit-Position: refs/heads/master@{#391393}

[brettw, 2016-05-03 03:31:05]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2016-05-03 03:31:10]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 03:31:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1946433002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1946433002/1

[commit-bot: I haz the power, 2016-05-03 04:20:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 04:20:13]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-05-03 17:48:50]

https://codereview.chromium.org/1946433002/diff/1/build/toolchain/win/BUILD.gn
File build/toolchain/win/BUILD.gn (right):

https://codereview.chromium.org/1946433002/diff/1/build/toolchain/win/BUILD.g...
build/toolchain/win/BUILD.gn:246: }
I'm confused; isn't this exactly the same?

[brettw, 2016-05-03 18:00:44]

https://codereview.chromium.org/1946433002/diff/1/build/toolchain/win/BUILD.gn
File build/toolchain/win/BUILD.gn (right):

https://codereview.chromium.org/1946433002/diff/1/build/toolchain/win/BUILD.g...
build/toolchain/win/BUILD.gn:246: }
On 2016/05/03 17:48:50, Dirk Pranke wrote:
> I'm confused; isn't this exactly the same?

With the new changes to forward_variables_from, it won't clobber a variable
implicitly. In the rare cases where you want to clobber, you need to do it
explicitly which is what happens here.

[Dirk Pranke, 2016-05-03 20:06:33]

lgtm w/ notes.

https://codereview.chromium.org/1946433002/diff/1/build/toolchain/win/BUILD.gn
File build/toolchain/win/BUILD.gn (right):

https://codereview.chromium.org/1946433002/diff/1/build/toolchain/win/BUILD.g...
build/toolchain/win/BUILD.gn:246: }
On 2016/05/03 18:00:43, brettw wrote:
> On 2016/05/03 17:48:50, Dirk Pranke wrote:
> > I'm confused; isn't this exactly the same?
> 
> With the new changes to forward_variables_from, it won't clobber a variable
> implicitly. In the rare cases where you want to clobber, you need to do it
> explicitly which is what happens here.

Ah, right, I was thinking they weren't already in scope but I wasn't thinking of
the top level declared_args.

Maybe add a comment indicating why using forward_variables_from() is the wrong
thing to do here and below, since that's non-obvious (although probably true for
all toolchain() rules)?

[brettw, 2016-05-03 21:34:36]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-05-03 21:34:37]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1946433002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-03 21:35:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1946433002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1946433002/20001

[commit-bot: I haz the power, 2016-05-03 23:27:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-03 23:29:13]

Description was changed from

==========
Windows GN clobber error fixes

The change http://crrev.com/1943583002/ introduced a new check for clobbering on
forward_variables_from. This patch fixes the associated errors for the Windows
build.
==========

to

==========
Windows GN clobber error fixes

The change http://crrev.com/1943583002/ introduced a new check for clobbering on
forward_variables_from. This patch fixes the associated errors for the Windows
build.

Committed: https://crrev.com/3003018ab361c53988d66b80dbed84c76def5c3d
Cr-Commit-Position: refs/heads/master@{#391393}
==========

[commit-bot: I haz the power, 2016-05-03 23:29:14]

Patchset 2 (id:??) landed as
https://crrev.com/3003018ab361c53988d66b80dbed84c76def5c3d
Cr-Commit-Position: refs/heads/master@{#391393}