third_party/WebKit/Source/core/layout/LayoutTable.cpp - Issue 1946413002: Avoid overflow recalc on tables if sections need rebuild

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTable.cpp

Issue 1946413002: Avoid overflow recalc on tables if sections need rebuild (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/repaint/checkbox-selection-rect-in-cell-expected.txt ('K') | « third_party/WebKit/LayoutTests/fast/repaint/checkbox-selection-rect-in-cell-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTable.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTable.cpp b/third_party/WebKit/Source/core/layout/LayoutTable.cpp

index c792917d29ab20c6786f14e074ef0461765cda50..1c6950a782bc55916927e76c49ffee717c8697e1 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTable.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTable.cpp

@@ -419,9 +419,9 @@ bool LayoutTable::recalcChildOverflowAfterStyleChange()

ASSERT(childNeedsOverflowRecalcAfterStyleChange());

clearChildNeedsOverflowRecalcAfterStyleChange();

- // If the table needs layout the sections we keep pointers to may have gone away and

+ // If the table sections we keep pointers to have gone away then the table will be rebuilt and

// overflow will get recalculated anyway so return early.

- if (needsLayout())

+ if (needsSectionRecalc())

return false;

bool childrenOverflowChanged = false;