Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTable.cpp

Issue 1946413002: Avoid overflow recalc on tables if sections need rebuild (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 401 matching lines...) Expand 10 before | Expand all | Expand 10 after
412 section->updateLayerTransformAfterLayout(); 412 section->updateLayerTransformAfterLayout();
413 section->addVisualEffectOverflow(); 413 section->addVisualEffectOverflow();
414 } 414 }
415 } 415 }
416 416
417 bool LayoutTable::recalcChildOverflowAfterStyleChange() 417 bool LayoutTable::recalcChildOverflowAfterStyleChange()
418 { 418 {
419 ASSERT(childNeedsOverflowRecalcAfterStyleChange()); 419 ASSERT(childNeedsOverflowRecalcAfterStyleChange());
420 clearChildNeedsOverflowRecalcAfterStyleChange(); 420 clearChildNeedsOverflowRecalcAfterStyleChange();
421 421
422 // If the table needs layout the sections we keep pointers to may have gone away and 422 // If the table sections we keep pointers to have gone away then the table w ill be rebuilt and
423 // overflow will get recalculated anyway so return early. 423 // overflow will get recalculated anyway so return early.
424 if (needsLayout()) 424 if (needsSectionRecalc())
425 return false; 425 return false;
426 426
427 bool childrenOverflowChanged = false; 427 bool childrenOverflowChanged = false;
428 for (LayoutTableSection* section = topSection(); section; section = sectionB elow(section)) { 428 for (LayoutTableSection* section = topSection(); section; section = sectionB elow(section)) {
429 if (!section->childNeedsOverflowRecalcAfterStyleChange()) 429 if (!section->childNeedsOverflowRecalcAfterStyleChange())
430 continue; 430 continue;
431 childrenOverflowChanged |= section->recalcChildOverflowAfterStyleChange( ); 431 childrenOverflowChanged |= section->recalcChildOverflowAfterStyleChange( );
432 } 432 }
433 return childrenOverflowChanged; 433 return childrenOverflowChanged;
434 } 434 }
(...skipping 1045 matching lines...) Expand 10 before | Expand all | Expand 10 after
1480 1480
1481 LayoutUnit LayoutTable::paddingRight() const 1481 LayoutUnit LayoutTable::paddingRight() const
1482 { 1482 {
1483 if (collapseBorders()) 1483 if (collapseBorders())
1484 return LayoutUnit(); 1484 return LayoutUnit();
1485 1485
1486 return LayoutBlock::paddingRight(); 1486 return LayoutBlock::paddingRight();
1487 } 1487 }
1488 1488
1489 } // namespace blink 1489 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698