logmetrics: Run as a service on skia-monitoring.

logmetrics: Run as a service on skia-monitoring.

BUG=skia:

Committed: https://skia.googlesource.com/buildbot/+/aa61950bfba5fe2cc5afe029c0ec5b3adc6ed001

[jcgregorio, 2016-05-05 16:25:36]

jcgregorio@google.com changed reviewers:
+ benjaminwagner@google.com

[dogben, 2016-05-05 16:45:35]

lgtm

Two comments below; otherwise LGTM.

https://codereview.chromium.org/1946333004/diff/1/logmetrics/Makefile
File logmetrics/Makefile (right):

https://codereview.chromium.org/1946333004/diff/1/logmetrics/Makefile#newcode6
logmetrics/Makefile:6: ./build_release "`git log -n1 --format=%s`"
+1; what happens if the commit message contains "?

https://codereview.chromium.org/1946333004/diff/1/logmetrics/Makefile#newcode8
logmetrics/Makefile:8: pushcli logmetric skia-monitoring
+2; "logmetric" -> "logmetrics"

[jcgregorio, 2016-05-05 17:01:42]

https://codereview.chromium.org/1946333004/diff/1/logmetrics/Makefile
File logmetrics/Makefile (right):

https://codereview.chromium.org/1946333004/diff/1/logmetrics/Makefile#newcode6
logmetrics/Makefile:6: ./build_release "`git log -n1 --format=%s`"
On 2016/05/05 at 16:45:35, Ben Wagner wrote:
> +1; what happens if the commit message contains "?

Then build_release would have either 3+2n quotes, and would be malformed bash
that would fail to run, or would have 4+2n quotes and would be well formed bash,
but build_release would failed because it expects a single argument.

https://codereview.chromium.org/1946333004/diff/1/logmetrics/Makefile#newcode8
logmetrics/Makefile:8: pushcli logmetric skia-monitoring
On 2016/05/05 at 16:45:35, Ben Wagner wrote:
> +2; "logmetric" -> "logmetrics"

Fixed.

[jcgregorio, 2016-05-05 17:01:43]

The CQ bit was checked by jcgregorio@google.com

[jcgregorio, 2016-05-05 17:01:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
benjaminwagner@google.com
Link to the patchset: https://codereview.chromium.org/1946333004/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-05 17:01:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1946333004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1946333004/20001

[commit-bot: I haz the power, 2016-05-05 17:04:44]

Description was changed from

==========
logmetrics: Run as a service on skia-monitoring.

BUG=skia:
==========

to

==========
logmetrics: Run as a service on skia-monitoring.

BUG=skia:

Committed:
https://skia.googlesource.com/buildbot/+/aa61950bfba5fe2cc5afe029c0ec5b3adc6e...
==========

[commit-bot: I haz the power, 2016-05-05 17:04:45]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/aa61950bfba5fe2cc5afe029c0ec5b3adc6e...