logmetrics/Makefile - Issue 1946333004: logmetrics: Run as a service on skia-monitoring.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: logmetrics/Makefile

Issue 1946333004: logmetrics: Run as a service on skia-monitoring. (Closed) Base URL: https://skia.googlesource.com/buildbot@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 default:	1 default:

2 go install -v ./go/logmetrics	2 go install -v ./go/logmetrics

	3

	4 .PHONY: push

	5 push: default

	6 ./build_release "`git log -n1 --format=%s`"
	dogben 2016/05/05 16:45:35 +1; what happens if the commit message contains "? +1; what happens if the commit message contains "? jcgregorio 2016/05/05 17:01:42 Then build_release would have either 3+2n quotes, Show quoted text On 2016/05/05 at 16:45:35, Ben Wagner wrote: > +1; what happens if the commit message contains "? Then build_release would have either 3+2n quotes, and would be malformed bash that would fail to run, or would have 4+2n quotes and would be well formed bash, but build_release would failed because it expects a single argument.
	7 go install -v ../push/go/pushcli

	8 pushcli logmetric skia-monitoring
	dogben 2016/05/05 16:45:35 +2; "logmetric" -> "logmetrics" +2; "logmetric" -> "logmetrics" jcgregorio 2016/05/05 17:01:42 Fixed. Show quoted text On 2016/05/05 at 16:45:35, Ben Wagner wrote: > +2; "logmetric" -> "logmetrics" Fixed.
OLD	NEW

« no previous file with comments | « no previous file | logmetrics/build_release » ('j') | no next file with comments »