Improve the instance-view page in observatory.

runtime/bin/vmservice/client/lib/src/service/service.dart

Index: runtime/bin/vmservice/client/lib/src/service/service.dart
diff --git a/runtime/bin/vmservice/client/lib/src/service/service.dart b/runtime/bin/vmservice/client/lib/src/service/service.dart
index e2c9aa4e00b3e0699476c479ad709ee88b07273b..88f32b95d5d6ec42dc013f86b7f26f2fd312b0ae 100644
--- a/runtime/bin/vmservice/client/lib/src/service/service.dart
+++ b/runtime/bin/vmservice/client/lib/src/service/service.dart
@@ -163,6 +163,9 @@ void _upgradeObservableList(ObservableList list, VM vm, Isolate isolate) {
 /// This acts like a factory which consumes an ObservableMap and returns
 /// a fully upgraded ServiceObject.
 ServiceObject _upgradeToServiceObject(VM vm, Isolate isolate, ObservableMap m) {
+  if (!ServiceObject.isServiceMap(m)) {
+    Logger.root.error("Malformed service object: $m");

[Cutch, 2014/03/11 22:06:46]

I was in the kitchen getting water and thought we should add this. WOOOAAH.

[turnidge, 2014/03/11 22:23:22]

Indeed.

+  }
   assert(ServiceObject.isServiceMap(m));
   var type = ServiceObject.stripRef(m['type']);
   switch (type) {
@@ -181,4 +184,4 @@ ServiceObject _upgradeToServiceObject(VM vm, Isolate isolate, ObservableMap m) {
       return isolate.classes.putIfAbsent(m);
   }
   return new ServiceMap.fromMap(isolate, m);
-}
+}