Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1946073002: Fix xdiff lib build file for windows (Closed)

Created:
4 years, 7 months ago by Ankur Mittal
Modified:
4 years, 7 months ago
Reviewers:
Petr Hosek
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/third_party.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Fix xdiff lib build file for windows Passing correct flags to visual studio compiler for windows system and removing unused linux specidifc header file BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4371 R=phosek@chromium.org Committed: https://chromium.googlesource.com/native_client/src/third_party/+/26e2269aa95582c9ad1f2c7e947e67c10eb96e99

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Format Build File #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M xdiff/BUILD.gn View 1 2 1 chunk +9 lines, -2 lines 0 comments Download
M xdiff/xinclude.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Ankur Mittal
PTAL
4 years, 7 months ago (2016-05-04 00:54:53 UTC) #7
Petr Hosek
Can you run gn format --in-place on the BUILD.gn file?
4 years, 7 months ago (2016-05-04 01:01:35 UTC) #8
Ankur Mittal
done
4 years, 7 months ago (2016-05-04 01:03:34 UTC) #9
Petr Hosek
lgtm
4 years, 7 months ago (2016-05-04 01:08:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946073002/40001
4 years, 7 months ago (2016-05-04 01:09:06 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: nacl-arm_opt_panda on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/nacl-arm_opt_panda/builds/11413) nacl-mac_arm_newlib_opt on tryserver.nacl (JOB_FAILED, ...
4 years, 7 months ago (2016-05-04 01:10:16 UTC) #14
Ankur Mittal
4 years, 7 months ago (2016-05-04 01:13:11 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
26e2269aa95582c9ad1f2c7e947e67c10eb96e99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698