xdiff/BUILD.gn - Issue 1946073002: Fix xdiff lib build file for windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xdiff/BUILD.gn

Issue 1946073002: Fix xdiff lib build file for windows (Closed) Base URL: https://chromium.googlesource.com/native_client/src/third_party.git@master

Patch Set: Format Build File Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xdiff/BUILD.gn

diff --git a/xdiff/BUILD.gn b/xdiff/BUILD.gn

index 8cc00dc2095b052dfd10c7fc5129cf117ed4afc1..cde09f331314d8ce1023202302aca76285b8df48 100644

--- a/xdiff/BUILD.gn

+++ b/xdiff/BUILD.gn

@@ -4,8 +4,15 @@

config("xdiff_config") {

visibility = [ ":*" ]

- cflags = [ "-Wno-sign-compare" ]

+ if (!is_clang && target_os == "win") {

+ cflags = [

+ "-wd4018",

+ "-wd4267",

+ "-wd4706",

+ ]

+ } else {

+ cflags = [ "-Wno-sign-compare" ]

+ }

}

static_library("xdiff") {

« no previous file with comments | « no previous file | xdiff/xinclude.h » ('j') | no next file with comments »