Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 194603004: Add elliptical-corner rrect clip effect. Currently only handles the case where all corners have the… (Closed)

Created:
6 years, 9 months ago by bsalomon
Modified:
6 years, 9 months ago
Reviewers:
jvanverth1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add elliptical-corner rrect clip effect. Currently only handles the case where all corners have the same pair of radii. BUG=skia:2181 Committed: http://code.google.com/p/skia/source/detail?r=13766

Patch Set 1 #

Patch Set 2 : rename prev effect to include word "circular" #

Patch Set 3 : rebase #

Patch Set 4 : rename rr effect vars #

Total comments: 2

Patch Set 5 : address comment, remove spurious params from appendf()s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -70 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 1 2 3 4 21 chunks +277 lines, -70 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bsalomon
6 years, 9 months ago (2014-03-11 15:32:46 UTC) #1
bsalomon
On 2014/03/11 15:32:46, bsalomon wrote: https://codereview.chromium.org/194703011/ extends this and fixes a few naming/comment nits.
6 years, 9 months ago (2014-03-11 21:02:24 UTC) #2
jvanverth1
lgtm + comment https://codereview.chromium.org/194603004/diff/60001/src/gpu/effects/GrRRectEffect.cpp File src/gpu/effects/GrRRectEffect.cpp (right): https://codereview.chromium.org/194603004/diff/60001/src/gpu/effects/GrRRectEffect.cpp#newcode380 src/gpu/effects/GrRRectEffect.cpp:380: // This effect only supports circular ...
6 years, 9 months ago (2014-03-12 13:44:28 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-12 14:17:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/194603004/80001
6 years, 9 months ago (2014-03-12 14:17:24 UTC) #5
bsalomon
https://codereview.chromium.org/194603004/diff/60001/src/gpu/effects/GrRRectEffect.cpp File src/gpu/effects/GrRRectEffect.cpp (right): https://codereview.chromium.org/194603004/diff/60001/src/gpu/effects/GrRRectEffect.cpp#newcode380 src/gpu/effects/GrRRectEffect.cpp:380: // This effect only supports circular corner rrects where ...
6 years, 9 months ago (2014-03-12 14:20:15 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 15:32:53 UTC) #7
Message was sent while issue was closed. 
Change committed as 13766

Powered by Google App Engine
This is Rietveld 408576698