Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1946003003: S390: Fix Macro-Asm DCHECK (Closed)

Created:
4 years, 7 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fix Macro-Asm DCHECK Move DCHECK to only check for necessary path. R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/60c0389b29ff871ec9098728473c3fef94c0837a Cr-Commit-Position: refs/heads/master@{#36034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/s390/macro-assembler-s390.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 7 months ago (2016-05-04 13:47:38 UTC) #1
JoranSiu
On 2016/05/04 13:47:38, john.yan wrote: > PTAL lgtm
4 years, 7 months ago (2016-05-04 13:57:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946003003/1
4 years, 7 months ago (2016-05-04 16:20:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 16:50:27 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 16:51:10 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/60c0389b29ff871ec9098728473c3fef94c0837a
Cr-Commit-Position: refs/heads/master@{#36034}

Powered by Google App Engine
This is Rietveld 408576698