Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: src/s390/macro-assembler-s390.cc

Issue 1946003003: S390: Fix Macro-Asm DCHECK (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/s390/macro-assembler-s390.cc
diff --git a/src/s390/macro-assembler-s390.cc b/src/s390/macro-assembler-s390.cc
index e22cea9ba2c8eeee8519a97faff965bf3003e1c9..519cc4ac1b3f92f107301a7e516810f7ab690cc6 100644
--- a/src/s390/macro-assembler-s390.cc
+++ b/src/s390/macro-assembler-s390.cc
@@ -5215,12 +5215,12 @@ void MacroAssembler::ShiftRight(Register dst, Register src,
// Shift right logical for 32-bit integer types.
void MacroAssembler::ShiftRight(Register dst, Register src, Register val) {
- DCHECK(!dst.is(val)); // The lr/srl path clobbers val.
if (dst.is(src)) {
srl(dst, val);
} else if (CpuFeatures::IsSupported(DISTINCT_OPS)) {
srlk(dst, src, val);
} else {
+ DCHECK(!dst.is(val)); // The lr/srl path clobbers val.
lr(dst, src);
srl(dst, val);
}
@@ -5241,12 +5241,12 @@ void MacroAssembler::ShiftLeftArith(Register dst, Register src,
// Shift left arithmetic for 32-bit integer types.
void MacroAssembler::ShiftLeftArith(Register dst, Register src, Register val) {
- DCHECK(!dst.is(val)); // The lr/sla path clobbers val.
if (dst.is(src)) {
sla(dst, val);
} else if (CpuFeatures::IsSupported(DISTINCT_OPS)) {
slak(dst, src, val);
} else {
+ DCHECK(!dst.is(val)); // The lr/sla path clobbers val.
lr(dst, src);
sla(dst, val);
}
@@ -5267,12 +5267,12 @@ void MacroAssembler::ShiftRightArith(Register dst, Register src,
// Shift right arithmetic for 32-bit integer types.
void MacroAssembler::ShiftRightArith(Register dst, Register src, Register val) {
- DCHECK(!dst.is(val)); // The lr/sra path clobbers val.
if (dst.is(src)) {
sra(dst, val);
} else if (CpuFeatures::IsSupported(DISTINCT_OPS)) {
srak(dst, src, val);
} else {
+ DCHECK(!dst.is(val)); // The lr/sra path clobbers val.
lr(dst, src);
sra(dst, val);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698