third_party/WebKit/Source/core/timing/PerformanceObserver.h - Issue 1945953002: Fix an edge case where early disconnect() can omit delivering of observation. crbug/607324

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceObserver.h

Issue 1945953002: Fix an edge case where early disconnect() can omit delivering of observation. crbug/607324 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing CORE_EXPORT to PerformanceObserver class Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp ('k') | third_party/WebKit/Source/core/timing/PerformanceObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/timing/PerformanceObserver.h

diff --git a/third_party/WebKit/Source/core/timing/PerformanceObserver.h b/third_party/WebKit/Source/core/timing/PerformanceObserver.h

index 6fe610dce4bad5f5b19ad316c1eb17b5dd98d527..edd4969df51455dae342dda325a3d2262b3041d1 100644

--- a/third_party/WebKit/Source/core/timing/PerformanceObserver.h

+++ b/third_party/WebKit/Source/core/timing/PerformanceObserver.h

@@ -6,6 +6,7 @@

#define PerformanceObserver_h

#include "bindings/core/v8/ScriptWrappable.h"

+#include "core/CoreExport.h"

#include "core/timing/PerformanceEntry.h"

#include "platform/heap/Handle.h"

#include "wtf/Vector.h"

@@ -20,7 +21,7 @@ class PerformanceObserverInit;

using PerformanceEntryVector = HeapVector<Member<PerformanceEntry>>;

-class PerformanceObserver final : public GarbageCollected<PerformanceObserver>, public ScriptWrappable {

+class CORE_EXPORT PerformanceObserver final : public GarbageCollected<PerformanceObserver>, public ScriptWrappable {

DEFINE_WRAPPERTYPEINFO();

friend class PerformanceBase;

public: