Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceObserver.cpp

Issue 1945953002: Fix an edge case where early disconnect() can omit delivering of observation. crbug/607324 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing CORE_EXPORT to PerformanceObserver class Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/timing/PerformanceObserver.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/timing/PerformanceObserver.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp b/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp
index fdef12967f1b4fa32c4c27179c0accc677f36897..920a8d5ce3e84a6acd3a792946ff2c0fbc6d8802 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp
@@ -57,9 +57,10 @@ void PerformanceObserver::observe(const PerformanceObserverInit& observerInit, E
void PerformanceObserver::disconnect()
{
- m_performanceEntries.clear();
if (m_performance)
m_performance->unregisterPerformanceObserver(*this);
+
+ m_performanceEntries.clear();
m_isRegistered = false;
}
« no previous file with comments | « third_party/WebKit/Source/core/timing/PerformanceObserver.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698