Motown: Move responsibility for binding to MediaFactoryService::Product

Motown: Move responsibility for binding to MediaFactoryService::Product
MediaFactoryService::Product is a base class for the products of the
factory. Previously, it was just about the factory's ownership of the
product. This CL moves responsibility for the binding to Product as
well, eliminating some duplicated code. This change also introduces
RCHECK, a macro that products can use instead of DCHECK when a failure
should result in the shutdown of the product.

R=kulakowski@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/bfa19c495748f4fa4e6b616ba42e1d11b9006600

[dalesat, 2016-05-05 19:59:57]

Description was changed from

==========
Motown: Move responsibility for binding to MediaFactoryService::Product
MediaFactoryService::Product is a base class for the products of the
factory. Previously, it was just about the factory's ownership of the
product. This CL moves responsibility for the binding to Product as
well, eliminating some duplicated code. This change also introduces
RCHECK, a macro that products can use instead of DCHECK when a failure
should result in the shutdown of the product.
==========

to

==========
Motown: Move responsibility for binding to MediaFactoryService::Product
MediaFactoryService::Product is a base class for the products of the
factory. Previously, it was just about the factory's ownership of the
product. This CL moves responsibility for the binding to Product as
well, eliminating some duplicated code. This change also introduces
RCHECK, a macro that products can use instead of DCHECK when a failure
should result in the shutdown of the product.
==========

[dalesat, 2016-05-05 19:59:57]

dalesat@chromium.org changed reviewers:
+ kulakowski@chromium.org

[dalesat, 2016-05-05 20:00:10]

Please take a look. Thanks!

[kulakowski, 2016-05-05 21:36:30]

On 2016/05/05 20:00:10, dalesat wrote:
> Please take a look. Thanks!

What is the difference between RCHECK and CHECK? RCHECK is also very brittle as
it is only useable in functions returning void.

[kulakowski, 2016-05-05 21:46:19]

So yeah. The functional change is awesome. A better name for Abort() and you're
golden.

https://codereview.chromium.org/1945903006/diff/1/services/media/factory_serv...
File services/media/factory_service/factory_service.h (right):

https://codereview.chromium.org/1945903006/diff/1/services/media/factory_serv...
services/media/factory_service/factory_service.h:120: Abort();                  
                                   \
Ah. |abort| is overloaded. I think this (and the comment above) would be much
clearer if the name were slightly more verbose. I read the comment as referring
to http://en.cppreference.com/w/cpp/utility/program/abort which would be a much
different change.

[dalesat, 2016-05-05 22:41:06]

https://codereview.chromium.org/1945903006/diff/1/services/media/factory_serv...
File services/media/factory_service/factory_service.h (right):

https://codereview.chromium.org/1945903006/diff/1/services/media/factory_serv...
services/media/factory_service/factory_service.h:120: Abort();                  
                                   \
On 2016/05/05 21:46:18, kulakowski wrote:
> Ah. |abort| is overloaded. I think this (and the comment above) would be much
> clearer if the name were slightly more verbose. I read the comment as
referring
> to http://en.cppreference.com/w/cpp/utility/program/abort which would be a
much
> different change.

Done.

[kulakowski, 2016-05-05 22:42:53]

lgtm

[dalesat, 2016-05-05 22:53:30]

Description was changed from

==========
Motown: Move responsibility for binding to MediaFactoryService::Product
MediaFactoryService::Product is a base class for the products of the
factory. Previously, it was just about the factory's ownership of the
product. This CL moves responsibility for the binding to Product as
well, eliminating some duplicated code. This change also introduces
RCHECK, a macro that products can use instead of DCHECK when a failure
should result in the shutdown of the product.
==========

to

==========
Motown: Move responsibility for binding to MediaFactoryService::Product
MediaFactoryService::Product is a base class for the products of the
factory. Previously, it was just about the factory's ownership of the
product. This CL moves responsibility for the binding to Product as
well, eliminating some duplicated code. This change also introduces
RCHECK, a macro that products can use instead of DCHECK when a failure
should result in the shutdown of the product.

R=kulakowski@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/bfa19c495748f4fa4e6b616ba42...
==========

[dalesat, 2016-05-05 22:53:31]

Committed patchset #2 (id:20001) manually as
bfa19c495748f4fa4e6b616ba42e1d11b9006600 (presubmit successful).