Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: services/media/factory_service/media_player_impl.h

Issue 1945903006: Motown: Move responsibility for binding to MediaFactoryService::Product (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Change per feedback - rename Abort to UnbindAndReleaseFromOwner Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/media/factory_service/media_player_impl.h
diff --git a/services/media/factory_service/media_player_impl.h b/services/media/factory_service/media_player_impl.h
index f9f53df523ceb746c32a5f70ab1fa994033421ae..33a7595e3964637d6260d4482c347343c68478f9 100644
--- a/services/media/factory_service/media_player_impl.h
+++ b/services/media/factory_service/media_player_impl.h
@@ -20,7 +20,7 @@ namespace mojo {
namespace media {
// Mojo agent that renders streams from an origin specified by URL.
-class MediaPlayerImpl : public MediaFactoryService::Product,
+class MediaPlayerImpl : public MediaFactoryService::Product<MediaPlayer>,
public MediaPlayer {
public:
static std::shared_ptr<MediaPlayerImpl> Create(
@@ -119,7 +119,6 @@ class MediaPlayerImpl : public MediaFactoryService::Product,
uint64_t version = MediaSink::kInitialStatus,
MediaSinkStatusPtr status = nullptr);
- Binding<MediaPlayer> binding_;
MediaFactoryPtr factory_;
MediaDemuxPtr demux_;
std::vector<std::unique_ptr<Stream>> streams_;
« no previous file with comments | « services/media/factory_service/media_demux_impl.cc ('k') | services/media/factory_service/media_player_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698