Split generated libraries out of //build/linux

Split generated libraries out of //build/linux

This CL moves the definitions for the generated libraries out of //build/linux
and into sub-folders. This fixues an issue where pulling in build/linux could
force downstream users of //build to have libudev headers available.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/8490e057b86dcfa3acb519fb1ebf406da13420ce
Cr-Commit-Position: refs/heads/master@{#391516}

[dsinclair, 2016-05-03 20:14:11]

Description was changed from

==========
Split generated libraries out of //build/linux

This CL moves the definitions for the generated libraries out of //build/linux
and into sub-folders. This fixues an issue where pulling in build/linux could
force downstream users of //build to have libudev headers available.
==========

to

==========
Split generated libraries out of //build/linux

This CL moves the definitions for the generated libraries out of //build/linux
and into sub-folders. This fixues an issue where pulling in build/linux could
force downstream users of //build to have libudev headers available.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[dsinclair, 2016-05-03 20:15:17]

dsinclair@chromium.org changed reviewers:
+ brettw@chromium.org, thakis@chromium.org

[dsinclair, 2016-05-03 20:15:18]

PTAL.

[brettw, 2016-05-03 20:22:03]

https://codereview.chromium.org/1945893002/diff/1/build/linux/libbrlapi/BUILD.gn
File build/linux/libbrlapi/BUILD.gn (right):

https://codereview.chromium.org/1945893002/diff/1/build/linux/libbrlapi/BUILD...
build/linux/libbrlapi/BUILD.gn:1: # Copyright (c) 2015 The Chromium Authors. All
rights reserved.
New copyright notice doesn't include (c)

https://codereview.chromium.org/1945893002/diff/1/build/linux/libbrlapi/BUILD...
build/linux/libbrlapi/BUILD.gn:7: gypi_values =
exec_script("//build/gypi_to_gn.py",
If we wanted to keep doing the gypi_to_gn thing here for these function names,
we should put it in a .gni file so the script only has to be run once. This will
save forking Python for every BUILD file you made (since the result of imports
are cached).

However, the Linux GYP build is effectively dead at this point so I don't think
we need to be doing this at all any more. I think we should just inline the list
of functions for each of the targets here and delete the gypi_to_gn calls.

[dsinclair, 2016-05-03 20:48:02]

https://codereview.chromium.org/1945893002/diff/1/build/linux/libbrlapi/BUILD.gn
File build/linux/libbrlapi/BUILD.gn (right):

https://codereview.chromium.org/1945893002/diff/1/build/linux/libbrlapi/BUILD...
build/linux/libbrlapi/BUILD.gn:1: # Copyright (c) 2015 The Chromium Authors. All
rights reserved.
On 2016/05/03 20:22:03, brettw wrote:
> New copyright notice doesn't include (c)

Done.

https://codereview.chromium.org/1945893002/diff/1/build/linux/libbrlapi/BUILD...
build/linux/libbrlapi/BUILD.gn:7: gypi_values =
exec_script("//build/gypi_to_gn.py",
On 2016/05/03 20:22:03, brettw wrote:
> If we wanted to keep doing the gypi_to_gn thing here for these function names,
> we should put it in a .gni file so the script only has to be run once. This
will
> save forking Python for every BUILD file you made (since the result of imports
> are cached).
> 
> However, the Linux GYP build is effectively dead at this point so I don't
think
> we need to be doing this at all any more. I think we should just inline the
list
> of functions for each of the targets here and delete the gypi_to_gn calls.

Done.

[brettw, 2016-05-03 21:03:03]

lgtm

https://codereview.chromium.org/1945893002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/BUILD.gn (right):

https://codereview.chromium.org/1945893002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/BUILD.gn:174: deps += [
"//build/linux/libbrlapi:libbrlapi" ]
This can just be
  deps += [ "//build/linux/libbrlapi" ]

https://codereview.chromium.org/1945893002/diff/20001/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/1945893002/diff/20001/chrome/browser/ui/BUILD...
chrome/browser/ui/BUILD.gn:325: "//build/linux/libgio:gio",
Can this target be called "libgio" and then you can just reference it as
"//build/linux/libgio"

https://codereview.chromium.org/1945893002/diff/20001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/1945893002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:1319: deps += [ "//build/linux/libbrlapi:libbrlapi" ]
Ditto for these other ones. Sorry I didn't notice this in the first pass.

[dsinclair, 2016-05-04 13:22:04]

https://codereview.chromium.org/1945893002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/BUILD.gn (right):

https://codereview.chromium.org/1945893002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/BUILD.gn:174: deps += [
"//build/linux/libbrlapi:libbrlapi" ]
On 2016/05/03 21:03:03, brettw wrote:
> This can just be
>   deps += [ "//build/linux/libbrlapi" ]

Done.

https://codereview.chromium.org/1945893002/diff/20001/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/1945893002/diff/20001/chrome/browser/ui/BUILD...
chrome/browser/ui/BUILD.gn:325: "//build/linux/libgio:gio",
On 2016/05/03 21:03:03, brettw wrote:
> Can this target be called "libgio" and then you can just reference it as
> "//build/linux/libgio"

Done.

https://codereview.chromium.org/1945893002/diff/20001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/1945893002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:1319: deps += [ "//build/linux/libbrlapi:libbrlapi" ]
On 2016/05/03 21:03:03, brettw wrote:
> Ditto for these other ones. Sorry I didn't notice this in the first pass.

Done.

[dsinclair, 2016-05-04 13:22:09]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-05-04 13:22:10]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1945893002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-04 13:22:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1945893002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1945893002/40001

[commit-bot: I haz the power, 2016-05-04 15:33:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-04 15:34:49]

Description was changed from

==========
Split generated libraries out of //build/linux

This CL moves the definitions for the generated libraries out of //build/linux
and into sub-folders. This fixues an issue where pulling in build/linux could
force downstream users of //build to have libudev headers available.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Split generated libraries out of //build/linux

This CL moves the definitions for the generated libraries out of //build/linux
and into sub-folders. This fixues an issue where pulling in build/linux could
force downstream users of //build to have libudev headers available.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/8490e057b86dcfa3acb519fb1ebf406da13420ce
Cr-Commit-Position: refs/heads/master@{#391516}
==========

[commit-bot: I haz the power, 2016-05-04 15:34:50]

Patchset 3 (id:??) landed as
https://crrev.com/8490e057b86dcfa3acb519fb1ebf406da13420ce
Cr-Commit-Position: refs/heads/master@{#391516}