build/linux/libbrlapi/BUILD.gn - Issue 1945893002: Split generated libraries out of //build/linux

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/linux/libbrlapi/BUILD.gn

Issue 1945893002: Split generated libraries out of //build/linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright (c) 2015 The Chromium Authors. All rights reserved.
	brettw 2016/05/03 20:22:03 New copyright notice doesn't include (c) New copyright notice doesn't include (c) dsinclair 2016/05/03 20:48:02 Done. Show quoted text On 2016/05/03 20:22:03, brettw wrote: > New copyright notice doesn't include (c) Done.
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import("//tools/generate_library_loader/generate_library_loader.gni")

	6

	7 gypi_values = exec_script("//build/gypi_to_gn.py",
	brettw 2016/05/03 20:22:03 If we wanted to keep doing the gypi_to_gn thing he If we wanted to keep doing the gypi_to_gn thing here for these function names, we should put it in a .gni file so the script only has to be run once. This will save forking Python for every BUILD file you made (since the result of imports are cached). However, the Linux GYP build is effectively dead at this point so I don't think we need to be doing this at all any more. I think we should just inline the list of functions for each of the targets here and delete the gypi_to_gn calls. dsinclair 2016/05/03 20:48:02 Done. Show quoted text On 2016/05/03 20:22:03, brettw wrote: > If we wanted to keep doing the gypi_to_gn thing here for these function names, > we should put it in a .gni file so the script only has to be run once. This will > save forking Python for every BUILD file you made (since the result of imports > are cached). > > However, the Linux GYP build is effectively dead at this point so I don't think > we need to be doing this at all any more. I think we should just inline the list > of functions for each of the targets here and delete the gypi_to_gn calls. Done.
	8 [ rebase_path("../system.gyp") ],

	9 "scope",

	10 [ "../system.gyp" ])

	11

	12 # TODO(GYP) linux_link_brlapi support. Is this needed?

	13 generate_library_loader("libbrlapi") {

	14 name = "LibBrlapiLoader"

	15 output_h = "libbrlapi.h"

	16 output_cc = "libbrlapi_loader.cc"

	17 header = "<brlapi.h>"

	18 config = ":brlapi_config"

	19

	20 functions = gypi_values.libbrlapi_functions

	21 }

OLD	NEW

« no previous file with comments | « build/linux/BUILD.gn ('k') | build/linux/libgio/BUILD.gn » ('j') | no next file with comments »