Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1945693002: Create a single, unique pointer to sRGB color space (Closed)

Created:
4 years, 7 months ago by msarett
Modified:
4 years, 7 months ago
Reviewers:
herb_g, Brian Osman, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase + Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -18 lines) Patch
M src/codec/SkPngCodec.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkColorSpace.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkColorSpace.cpp View 1 5 chunks +46 lines, -11 lines 0 comments Download
M tests/ColorSpaceTest.cpp View 1 2 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
msarett
Mike, I will make sure this lands after your CL :). Herb, let me know ...
4 years, 7 months ago (2016-05-03 15:16:49 UTC) #3
msarett
PTAL, I've rebased and added a test.
4 years, 7 months ago (2016-05-03 20:23:49 UTC) #4
Brian Osman
lgtm
4 years, 7 months ago (2016-05-03 20:50:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945693002/20001
4 years, 7 months ago (2016-05-03 21:13:47 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 21:24:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/02125d10d5d021f1f3190ca95a3ef62b43349a64

Powered by Google App Engine
This is Rietveld 408576698