Create a single, unique pointer to sRGB color space

src/core/SkColorSpace.h

 /*
  * Copyright 2016 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkColorSpace_DEFINED
 #define SkColorSpace_DEFINED
 
@@ skipping 102 matching lines @@
         SkGammaCurve fGreen;
         SkGammaCurve fBlue;
 
         friend class SkColorSpace;
     };
 
     /**
      *  Return a colorspace instance, given a 3x3 transform from linear_RGB to D50_XYZ
      *  and the src-gamma, return a ColorSpace
      */
-    static sk_sp<SkColorSpace> NewRGB(const SkFloat3x3& toXYZD50, SkGammas gammas);
+    static sk_sp<SkColorSpace> NewRGB(SkGammas gammas, const SkFloat3x3& toXYZD50);

[msarett, 2016/05/03 15:16:49]

Reverse parameter order to match the rest of the file.  I find it logical to
list the objects in the order that they should be applied to the encoded data.

 
     static sk_sp<SkColorSpace> NewNamed(Named);
     static sk_sp<SkColorSpace> NewICC(const void*, size_t);
 
     const SkGammas& gammas() const { return fGammas; }
     SkFloat3x3 xyz() const { return fToXYZD50; }
     SkFloat3 xyzOffset() const { return fToXYZOffset; }
     Named named() const { return fNamed; }
     uint32_t uniqueID() const { return fUniqueID; }
 
@@ skipping 17 matching lines @@
     const SkColorLookUpTable fColorLUT;
     const SkGammas           fGammas;
     const SkFloat3x3         fToXYZD50;
     const SkFloat3           fToXYZOffset;
 
     const uint32_t           fUniqueID;
     const Named              fNamed;
 };
 
 #endif