Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1945663002:
DoA: Add blink (platform) to public_deps in blimp/client:feature (Closed)
|
Created:
4 years, 7 months ago by Mark Dittmer Modified:
4 years, 7 months ago CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, Fady Samuel Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove blink_headers to public_deps in blimp/client:feature
BUG=608715
Patch Set 1 #Patch Set 2 : Fix linkage dep, not header dep #
Total comments: 1
Messages
Total messages: 18 (7 generated)
The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945663002/1
Description was changed from ========== Move blink_headers to public_deps in blimp/client:feature BUG=608715 ========== to ========== Move blink_headers to public_deps in blimp/client:feature BUG=608715 ==========
markdittmer@chromium.org changed reviewers: + wez@chromium.org
Just noticed this blimp build failure this morning. Wez, PTAL at candidate fix.
Fix linkage dep, not header dep
This works AS A TEMPORARY FIX. The root cause appears to be a dep issue between content/common and WebKit. See https://bugs.chromium.org/p/chromium/issues/detail?id=608718.
The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945663002/20001
maniscalco@chromium.org changed reviewers: + kmarshall@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
wez@chromium.org changed reviewers: + nyquist@chromium.org - wez@chromium.org
wez -> nyquist, who has been looking at dependency issues in the Blimp build files.
https://codereview.chromium.org/1945663002/diff/20001/blimp/client/BUILD.gn File blimp/client/BUILD.gn (right): https://codereview.chromium.org/1945663002/diff/20001/blimp/client/BUILD.gn#n... blimp/client/BUILD.gn:141: "//third_party/WebKit/public:blink", Could you add a TODO to remove this, please? We really don't want this target to depend on blink.
On 2016/05/03 16:43:30, nyquist wrote: > https://codereview.chromium.org/1945663002/diff/20001/blimp/client/BUILD.gn > File blimp/client/BUILD.gn (right): > > https://codereview.chromium.org/1945663002/diff/20001/blimp/client/BUILD.gn#n... > blimp/client/BUILD.gn:141: "//third_party/WebKit/public:blink", > Could you add a TODO to remove this, please? We really don't want this target to > depend on blink. It looks like https://bugs.chromium.org/p/chromium/issues/detail?id=608114 is tracking this, and that https://codereview.chromium.org/1945473002 will be a permanent fix. @nyquist, is there still interest in me committing this patch with a TODO that refers to the issue linked above?
No, it would be great if you don't commit it. Thanks for following up! |
