Break dependencies of browser -> blink

Break dependencies of browser -> blink

In order to get assert_no_deps on, move a couple small implementation files to
blink_common (WebInputEvent.cpp and WebFontRenderStyle.cpp).

blimp_shell adds a dependency on blink, which it needs for
blink::WebFontRendering::setSkiaFontManager. I'm not sure what to do about that
one.

BUG=582206, 608114
Committed: https://crrev.com/581bbb4d26224e4dce31e93651af0df157901c60
Cr-Commit-Position: refs/heads/master@{#392105}

[scottmg, 2016-05-03 21:04:19]

Description was changed from

==========
Don't have/let nacl_helper depend on blink

BUG=608114
==========

to

==========
Break some dependencies of browser on blink

BUG=608114
==========

[scottmg, 2016-05-03 21:13:29]

Description was changed from

==========
Break some dependencies of browser on blink

BUG=608114
==========

to

==========
Break some dependencies of browser on blink

In order to get assert_no_deps on, move a couple implementation

BUG=608114
==========

[scottmg, 2016-05-03 21:14:29]

Description was changed from

==========
Break some dependencies of browser on blink

In order to get assert_no_deps on, move a couple implementation

BUG=608114
==========

to

==========
Break some dependencies of browser on blink

In order to get assert_no_deps on, move a couple small implementation files to
blink_common.

blimp_shell adds a dependency on blink, which it needs for
blink::WebFontRendering::setSkiaFontManager. I'm not sure what to do about that
one.

BUG=608114
==========

[scottmg, 2016-05-03 23:55:10]

Description was changed from

==========
Break some dependencies of browser on blink

In order to get assert_no_deps on, move a couple small implementation files to
blink_common.

blimp_shell adds a dependency on blink, which it needs for
blink::WebFontRendering::setSkiaFontManager. I'm not sure what to do about that
one.

BUG=608114
==========

to

==========
Break some dependencies of browser on blink

In order to get assert_no_deps on, move a couple small implementation files to
blink_common.

blimp_shell adds a dependency on blink, which it needs for
blink::WebFontRendering::setSkiaFontManager. I'm not sure what to do about that
one.

BUG=608114
==========

[scottmg, 2016-05-03 23:55:11]

scottmg@chromium.org changed reviewers:
+ jochen@chromium.org, wez@chromium.org

[scottmg, 2016-05-03 23:56:06]

Description was changed from

==========
Break some dependencies of browser on blink

In order to get assert_no_deps on, move a couple small implementation files to
blink_common.

blimp_shell adds a dependency on blink, which it needs for
blink::WebFontRendering::setSkiaFontManager. I'm not sure what to do about that
one.

BUG=608114
==========

to

==========
Break dependencies of browser -> blink

In order to get assert_no_deps on, move a couple small implementation files to
blink_common.

blimp_shell adds a dependency on blink, which it needs for
blink::WebFontRendering::setSkiaFontManager. I'm not sure what to do about that
one.

BUG=608114
==========

[scottmg, 2016-05-03 23:56:47]

Description was changed from

==========
Break dependencies of browser -> blink

In order to get assert_no_deps on, move a couple small implementation files to
blink_common.

blimp_shell adds a dependency on blink, which it needs for
blink::WebFontRendering::setSkiaFontManager. I'm not sure what to do about that
one.

BUG=608114
==========

to

==========
Break dependencies of browser -> blink

In order to get assert_no_deps on, move a couple small implementation files to
blink_common (WebInputEvent.cpp and WebFontRenderStyle.cpp).

blimp_shell adds a dependency on blink, which it needs for
blink::WebFontRendering::setSkiaFontManager. I'm not sure what to do about that
one.

BUG=608114
==========

[scottmg, 2016-05-03 23:58:30]

Description was changed from

==========
Break dependencies of browser -> blink

In order to get assert_no_deps on, move a couple small implementation files to
blink_common (WebInputEvent.cpp and WebFontRenderStyle.cpp).

blimp_shell adds a dependency on blink, which it needs for
blink::WebFontRendering::setSkiaFontManager. I'm not sure what to do about that
one.

BUG=608114
==========

to

==========
Break dependencies of browser -> blink

In order to get assert_no_deps on, move a couple small implementation files to
blink_common (WebInputEvent.cpp and WebFontRenderStyle.cpp).

blimp_shell adds a dependency on blink, which it needs for
blink::WebFontRendering::setSkiaFontManager. I'm not sure what to do about that
one.

BUG=582206,608114
==========

[scottmg, 2016-05-04 00:23:29]

wez: blimp/
jochen: the rest

[Khushal, 2016-05-04 02:02:18]

khushalsagar@chromium.org changed reviewers:
+ khushalsagar@chromium.org

[Khushal, 2016-05-04 02:02:19]

https://codereview.chromium.org/1945473002/diff/120001/blimp/client/BUILD.gn
File blimp/client/BUILD.gn (right):

https://codereview.chromium.org/1945473002/diff/120001/blimp/client/BUILD.gn#...
blimp/client/BUILD.gn:205: "//third_party/WebKit/public:blink",
blimp/client should not need to depend on blink. It is actually our dependency
on components/safe_json which is pulling in blink.

[scottmg, 2016-05-04 17:02:57]

https://codereview.chromium.org/1945473002/diff/120001/blimp/client/BUILD.gn
File blimp/client/BUILD.gn (right):

https://codereview.chromium.org/1945473002/diff/120001/blimp/client/BUILD.gn#...
blimp/client/BUILD.gn:205: "//third_party/WebKit/public:blink",
On 2016/05/04 02:02:19, Khushal wrote:
> blimp/client should not need to depend on blink. It is actually our dependency
> on components/safe_json which is pulling in blink.

safe_json may be another problem, but the link error I was seeing was I believe
due to
https://chromium.googlesource.com/chromium/src/+/12a558c16f853751ab702c84fbd0...
because content/zygote (browser) is calling into
blink::WebFontRendering::setSkiaFontManager.

[Khushal, 2016-05-04 18:09:30]

khushalsagar@chromium.org changed reviewers:
+ nyquist@chromium.org
- khushalsagar@chromium.org

[Khushal, 2016-05-04 18:09:31]

https://codereview.chromium.org/1945473002/diff/120001/blimp/client/BUILD.gn
File blimp/client/BUILD.gn (right):

https://codereview.chromium.org/1945473002/diff/120001/blimp/client/BUILD.gn#...
blimp/client/BUILD.gn:205: "//third_party/WebKit/public:blink",
On 2016/05/04 17:02:57, scottmg wrote:
> On 2016/05/04 02:02:19, Khushal wrote:
> > blimp/client should not need to depend on blink. It is actually our
dependency
> > on components/safe_json which is pulling in blink.
> 
> safe_json may be another problem, but the link error I was seeing was I
believe
> due to
>
https://chromium.googlesource.com/chromium/src/+/12a558c16f853751ab702c84fbd0...
> because content/zygote (browser) is calling into
> blink::WebFontRendering::setSkiaFontManager.

Sorry I missed this earlier. Thanks!
+nyquist@ to review since wez@ is OOO.

[nyquist, 2016-05-04 18:17:02]

blimp sadly lgtm. Glad Khushal is on it.

[jochen (gone - plz use gerrit), 2016-05-06 10:35:02]

lgtm

[scottmg, 2016-05-06 17:04:04]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-05-06 17:04:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1945473002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1945473002/140001

[commit-bot: I haz the power, 2016-05-06 18:35:27]

Description was changed from

==========
Break dependencies of browser -> blink

In order to get assert_no_deps on, move a couple small implementation files to
blink_common (WebInputEvent.cpp and WebFontRenderStyle.cpp).

blimp_shell adds a dependency on blink, which it needs for
blink::WebFontRendering::setSkiaFontManager. I'm not sure what to do about that
one.

BUG=582206,608114
==========

to

==========
Break dependencies of browser -> blink

In order to get assert_no_deps on, move a couple small implementation files to
blink_common (WebInputEvent.cpp and WebFontRenderStyle.cpp).

blimp_shell adds a dependency on blink, which it needs for
blink::WebFontRendering::setSkiaFontManager. I'm not sure what to do about that
one.

BUG=582206,608114
==========

[commit-bot: I haz the power, 2016-05-06 18:35:28]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-05-06 18:37:02]

Description was changed from

==========
Break dependencies of browser -> blink

In order to get assert_no_deps on, move a couple small implementation files to
blink_common (WebInputEvent.cpp and WebFontRenderStyle.cpp).

blimp_shell adds a dependency on blink, which it needs for
blink::WebFontRendering::setSkiaFontManager. I'm not sure what to do about that
one.

BUG=582206,608114
==========

to

==========
Break dependencies of browser -> blink

In order to get assert_no_deps on, move a couple small implementation files to
blink_common (WebInputEvent.cpp and WebFontRenderStyle.cpp).

blimp_shell adds a dependency on blink, which it needs for
blink::WebFontRendering::setSkiaFontManager. I'm not sure what to do about that
one.

BUG=582206,608114

Committed: https://crrev.com/581bbb4d26224e4dce31e93651af0df157901c60
Cr-Commit-Position: refs/heads/master@{#392105}
==========

[commit-bot: I haz the power, 2016-05-06 18:37:03]

Patchset 8 (id:??) landed as
https://crrev.com/581bbb4d26224e4dce31e93651af0df157901c60
Cr-Commit-Position: refs/heads/master@{#392105}