Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1945623002: Make sure computed style is up-to-date for custom properties. (Closed)

Created:
4 years, 7 months ago by rune
Modified:
4 years, 7 months ago
Reviewers:
shans
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure computed style is up-to-date for custom properties. For custom properties, we didn't call updateLayoutTreeForNode which meant the computed style object might return out-of-date values for custom properties. Did some cleanup in getPropertyCSSValue for known properties. R=shans@chromium.org BUG=608690 Committed: https://crrev.com/b4bf5e78fabe368cf4005dcb4b3adc19107afab5 Cr-Commit-Position: refs/heads/master@{#391368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/variables/computed-style.html View 3 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rune
ptal
4 years, 7 months ago (2016-05-03 13:00:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945623002/1
4 years, 7 months ago (2016-05-03 13:00:18 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 15:46:20 UTC) #5
shans
lgtm Thanks!
4 years, 7 months ago (2016-05-03 21:50:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945623002/1
4 years, 7 months ago (2016-05-03 21:51:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 21:58:32 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 21:59:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4bf5e78fabe368cf4005dcb4b3adc19107afab5
Cr-Commit-Position: refs/heads/master@{#391368}

Powered by Google App Engine
This is Rietveld 408576698