third_party/WebKit/LayoutTests/fast/css/variables/computed-style.html - Issue 1945623002: Make sure computed style is up-to-date for custom properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css/variables/computed-style.html

Issue 1945623002: Make sure computed style is up-to-date for custom properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/fast/css/variables/computed-style.html

diff --git a/third_party/WebKit/LayoutTests/fast/css/variables/computed-style.html b/third_party/WebKit/LayoutTests/fast/css/variables/computed-style.html

index 661ecdf9b75bad7be17d3dedeb76f26104b69587..da64b01340e95a8671c29baaf06b5645bc1c8f18 100644

--- a/third_party/WebKit/LayoutTests/fast/css/variables/computed-style.html

+++ b/third_party/WebKit/LayoutTests/fast/css/variables/computed-style.html

@@ -22,6 +22,10 @@

--percentage-value: 75%;

width: var(--percentage-value);

}

+#dynamic.dynamic {

+ --custom-value:pass;

</style>

<body>

@@ -29,6 +33,7 @@

+ <div id="dynamic"></div>

</body>

@@ -53,4 +58,10 @@ test(function() {

assert_equals(

getComputedStyle(percentage).width, parseInt(getComputedStyle(document.body).width) * 0.75 + 'px');

}, 'width property, percentage value');

+test(function() {

+ assert_equals(getComputedStyle(dynamic).getPropertyValue("--custom-value"), "");

+ dynamic.className = "dynamic";

+ assert_equals(getComputedStyle(dynamic).getPropertyValue("--custom-value"), "pass");

+}, 'custom property, forced style recalc');

</script>

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | no next file with comments »