Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1945583002: [NET] Del: Remove AddressSorterWinXP wrapper for AddressSorterWin (Closed)

Created:
4 years, 7 months ago by maksims (do not use this acc)
Modified:
4 years, 7 months ago
Reviewers:
Bence, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Since we are not supporting WinXP platform anymore, there is no need in AddressSorterWinXP wrapper for AddressSorterWin for address sorting. + Modified comment in the net/socket/tcp_socket_win.h in accordance to https://codereview.chromium.org/1626643002 BUG=580691 Committed: https://crrev.com/c8f527056c4653134fc76f01900b5f053adc8b05 Cr-Commit-Position: refs/heads/master@{#391461}

Patch Set 1 #

Patch Set 2 : remove not used function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -54 lines) Patch
M net/dns/address_sorter_win.cc View 1 1 chunk +0 lines, -53 lines 0 comments Download
M net/socket/tcp_socket_win.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
maksims (do not use this acc)
ptal
4 years, 7 months ago (2016-05-03 08:50:07 UTC) #4
Bence
I'm on leave (sorry for not having updated my nick earlier), removing myself.
4 years, 7 months ago (2016-05-03 20:30:49 UTC) #5
Ryan Hamilton
lgtm
4 years, 7 months ago (2016-05-03 23:16:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945583002/1
4 years, 7 months ago (2016-05-04 05:03:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/16509)
4 years, 7 months ago (2016-05-04 06:43:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945583002/20001
4 years, 7 months ago (2016-05-04 07:17:51 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 08:20:16 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 08:21:23 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c8f527056c4653134fc76f01900b5f053adc8b05
Cr-Commit-Position: refs/heads/master@{#391461}

Powered by Google App Engine
This is Rietveld 408576698