Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 1626643002: Remove code to set the send/receive buffer size on XP. (Closed)

Created:
4 years, 11 months ago by mmenke
Modified:
4 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove code to set the send/receive buffer size on XP. Since we're no longer supporting XP, this is no longer needed. Newer versions of windows automatically tune the buffer sizes. BUG=580691 Committed: https://crrev.com/3983f64a3c99469d868ca1107a35336732c7dd6a Cr-Commit-Position: refs/heads/master@{#371466}

Patch Set 1 #

Patch Set 2 : Remove header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M net/socket/tcp_socket_win.cc View 1 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mmenke
rch: PTAL. Sending it to you just because you're the last network stack person to ...
4 years, 11 months ago (2016-01-25 20:47:14 UTC) #2
Ryan Hamilton
lgtm Yay, old code removal!
4 years, 11 months ago (2016-01-26 04:56:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626643002/1
4 years, 11 months ago (2016-01-26 04:57:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626643002/20001
4 years, 11 months ago (2016-01-26 05:00:44 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 05:53:18 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 05:54:09 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3983f64a3c99469d868ca1107a35336732c7dd6a
Cr-Commit-Position: refs/heads/master@{#371466}

Powered by Google App Engine
This is Rietveld 408576698