Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1945383002: Update docs on how to update clang in Chromium (Closed)

Created:
4 years, 7 months ago by Reid Kleckner
Modified:
4 years, 7 months ago
Reviewers:
hans, Nico, krasin1, krasin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update docs on how to update clang in Chromium R=thakis@chromium.org,hans@chromium.org,krasin@chromium.org BUG= NOTRY=True Committed: https://crrev.com/61e1abc6d75fed9a1140940aecdc71fa2ce0eeee Cr-Commit-Position: refs/heads/master@{#391539}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M docs/updating_clang.md View 1 chunk +7 lines, -12 lines 1 comment Download

Messages

Total messages: 15 (7 generated)
Reid Kleckner
4 years, 7 months ago (2016-05-04 16:29:16 UTC) #1
hans
lgtm
4 years, 7 months ago (2016-05-04 16:30:40 UTC) #2
Nico
lgtm, thanks! https://codereview.chromium.org/1945383002/diff/1/docs/updating_clang.md File docs/updating_clang.md (right): https://codereview.chromium.org/1945383002/diff/1/docs/updating_clang.md#newcode10 docs/updating_clang.md:10: 1. Run an exhaustive set of try ...
4 years, 7 months ago (2016-05-04 16:33:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945383002/1
4 years, 7 months ago (2016-05-04 16:42:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945383002/1
4 years, 7 months ago (2016-05-04 16:42:52 UTC) #9
krasin
LGTM Thank you, Reid!
4 years, 7 months ago (2016-05-04 16:43:24 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 16:50:31 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 16:52:31 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/61e1abc6d75fed9a1140940aecdc71fa2ce0eeee
Cr-Commit-Position: refs/heads/master@{#391539}

Powered by Google App Engine
This is Rietveld 408576698