Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: docs/updating_clang.md

Issue 1945383002: Update docs on how to update clang in Chromium (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/updating_clang.md
diff --git a/docs/updating_clang.md b/docs/updating_clang.md
index 58fa00b769f7e4b7203f64e6fc3846b4bfda8522..7b4f98ed45d63b1de286e5647e6a93fd322d7ed5 100644
--- a/docs/updating_clang.md
+++ b/docs/updating_clang.md
@@ -1,18 +1,13 @@
# Updating clang
1. Sync your Chromium tree to the latest revision to pick up any plugin
- changes and test the new compiler against ToT
-1. Update clang revision in tools/clang/scripts/update.py, upload CL to
- rietveld
-1. Run tools/clang/scripts/package.py to create a tgz of the binary (mac and
- linux)
-1. Do a local clobber build with that clang (mac and linux). Check that
- everything builds fine and no new warnings appear. (Optional if the
- revision picked in 1 was vetted by other means already.)
-1. Upload the binaries using gsutil, they will appear at
- http://commondatastorage.googleapis.com/chromium-browser-clang/index.html
-1. Run goma package update script to push these packages to goma, send email
-1. `git cl try &&
+ changes
+1. Run `python tools/clang/scripts/upload_revision.py --clang_revision=NNNN`
+ with the target LLVM SVN revision number
+1. If the clang upload trybots succeed, run the goma package update script to
+ push these packages to goma. If you do not have the necessary credentials to
+ do the upload, ask clang@chromium.org to find someone who does
+1. Run an exhaustive set of try jobs to test the new compiler: `git cl try &&
Nico 2016/05/04 16:33:11 Maybe this could be `upload_revsion.py --send-try-
git cl try -m tryserver.chromium.mac -b mac_chromium_rel_ng -b
mac_chromium_asan_rel_ng -b mac_chromium_gn_dbg -b ios_rel_device_ninja &&
git cl try -m tryserver.chromium.linux -b linux_chromium_chromeos_dbg_ng
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698