Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1945303005: Change webapk packages and directory structure (Closed)

Created:
4 years, 7 months ago by pkotwicz
Modified:
4 years, 7 months ago
Reviewers:
Xi Han, Yaron
CC:
Yaron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change webapk packages and directory structure This CL: - Changes toplevel directory from web_apks/minting_example to webapk/ - Moves code for "Web APK shell" from web_apks/minting_example/src to webapk/shell_apk/src - Creates a BUILD.gn build file for each subdirectory - Replaces org.chromium.minting package with org.chromium.webapk BUG=609488

Patch Set 1 #

Patch Set 2 : #

Total comments: 7

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -2571 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/PackageReveiver.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/android/shell_apk/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download
D web_apks/minting_example/AndroidManifest.xml View 1 chunk +0 lines, -77 lines 0 comments Download
D web_apks/minting_example/BUILD.gn View 1 chunk +0 lines, -175 lines 0 comments Download
D web_apks/minting_example/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D web_apks/minting_example/javatests/canary_lib/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D web_apks/minting_example/javatests/canary_lib/src/org/chromium/minting/test/canary/Canary.java View 1 chunk +0 lines, -8 lines 0 comments Download
D web_apks/minting_example/javatests/dex_optimizer/AndroidManifest.xml View 1 chunk +0 lines, -21 lines 0 comments Download
D web_apks/minting_example/javatests/dex_optimizer/BUILD.gn View 1 chunk +0 lines, -25 lines 0 comments Download
D web_apks/minting_example/javatests/dex_optimizer/src/org/chromium/minting/test/dex_optimizer/DexOptimizerServiceImpl.java View 1 chunk +0 lines, -64 lines 0 comments Download
D web_apks/minting_example/javatests/dex_optimizer/src/org/chromium/minting/test/dex_optimizer/IDexOptimizerService.aidl View 1 chunk +0 lines, -13 lines 0 comments Download
D web_apks/minting_example/javatests/dex_optimizer/src/org/chromium/minting/test/dex_optimizer/common.aidl View 1 chunk +0 lines, -5 lines 0 comments Download
D web_apks/minting_example/javatests/src/org/chromium/minting/DexLoaderTest.java View 1 chunk +0 lines, -318 lines 0 comments Download
D web_apks/minting_example/junit/libs/runtime_library/src/org/chromium/minting/libs/runtime_library/WebApkServiceImplTest.java View 1 chunk +0 lines, -100 lines 0 comments Download
D web_apks/minting_example/libs/client/org/chromium/minting/lib/client/DexOptimizer.java View 1 chunk +0 lines, -189 lines 0 comments Download
D web_apks/minting_example/libs/client/org/chromium/minting/lib/client/NavigationClient.java View 1 chunk +0 lines, -55 lines 0 comments Download
D web_apks/minting_example/libs/client/org/chromium/minting/lib/client/NotificationBuilderDelegate.java View 1 chunk +0 lines, -43 lines 0 comments Download
D web_apks/minting_example/libs/client/org/chromium/minting/lib/client/NotificationClient.java View 1 chunk +0 lines, -135 lines 0 comments Download
D web_apks/minting_example/libs/client/org/chromium/minting/lib/client/WebApkStateParams.java View 1 chunk +0 lines, -46 lines 0 comments Download
D web_apks/minting_example/libs/client/org/chromium/minting/lib/client/WebApkSwitches.java View 1 chunk +0 lines, -14 lines 0 comments Download
D web_apks/minting_example/libs/client/org/chromium/minting/lib/client/WebApkValidator.java View 1 chunk +0 lines, -122 lines 0 comments Download
D web_apks/minting_example/libs/client/org/chromium/minting/lib/client/WebApkVersion.template View 1 chunk +0 lines, -11 lines 0 comments Download
D web_apks/minting_example/libs/client/org/chromium/minting/lib/client/WebApkVersionManager.java View 1 chunk +0 lines, -70 lines 0 comments Download
D web_apks/minting_example/libs/common/org/chromium/minting/lib/common/WebApkConstants.java View 1 chunk +0 lines, -16 lines 0 comments Download
D web_apks/minting_example/libs/common/org/chromium/minting/lib/common/WebApkUtils.java View 1 chunk +0 lines, -71 lines 0 comments Download
D web_apks/minting_example/libs/runtime_library/src/README View 1 chunk +0 lines, -14 lines 0 comments Download
D web_apks/minting_example/libs/runtime_library/src/org/chromium/minting/libs/runtime_library/IWebApkApi.aidl View 1 chunk +0 lines, -27 lines 0 comments Download
D web_apks/minting_example/libs/runtime_library/src/org/chromium/minting/libs/runtime_library/WebApkServiceImpl.java View 1 chunk +0 lines, -98 lines 0 comments Download
D web_apks/minting_example/libs/runtime_library/src/org/chromium/minting/libs/runtime_library/common.aidl View 1 chunk +0 lines, -7 lines 0 comments Download
D web_apks/minting_example/proguard.flags View 1 chunk +0 lines, -63 lines 0 comments Download
D web_apks/minting_example/res/drawable/app_icon.png View Binary file 0 comments Download
D web_apks/minting_example/res/layout/main.xml View 1 chunk +0 lines, -11 lines 0 comments Download
D web_apks/minting_example/src/org/chromium/minting/DexLoader.java View 1 chunk +0 lines, -147 lines 0 comments Download
D web_apks/minting_example/src/org/chromium/minting/MainActivity.java View 1 chunk +0 lines, -123 lines 0 comments Download
D web_apks/minting_example/src/org/chromium/minting/Reflect.java View 1 chunk +0 lines, -66 lines 0 comments Download
D web_apks/minting_example/src/org/chromium/minting/WebApkApplication.java View 1 chunk +0 lines, -155 lines 0 comments Download
D web_apks/minting_example/src/org/chromium/minting/WebApkServiceFactory.java View 1 chunk +0 lines, -168 lines 0 comments Download
A + webapk/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A webapk/libs/client/BUILD.gn View 1 chunk +36 lines, -0 lines 0 comments Download
A + webapk/libs/client/src/org/chromium/webapk/lib/client/DexOptimizer.java View 1 chunk +1 line, -1 line 0 comments Download
A + webapk/libs/client/src/org/chromium/webapk/lib/client/NavigationClient.java View 1 chunk +3 lines, -3 lines 0 comments Download
A + webapk/libs/client/src/org/chromium/webapk/lib/client/NotificationBuilderDelegate.java View 1 chunk +1 line, -1 line 0 comments Download
A + webapk/libs/client/src/org/chromium/webapk/lib/client/NotificationClient.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkStateParams.java View 1 chunk +1 line, -1 line 0 comments Download
A + webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkSwitches.java View 1 chunk +1 line, -1 line 0 comments Download
A + webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java View 1 chunk +2 lines, -2 lines 0 comments Download
A + webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVersion.template View 1 chunk +1 line, -1 line 0 comments Download
A + webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVersionManager.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + webapk/libs/common/BUILD.gn View 1 chunk +5 lines, -2 lines 0 comments Download
A + webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java View 1 chunk +3 lines, -3 lines 0 comments Download
A + webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkUtils.java View 1 chunk +1 line, -1 line 0 comments Download
A webapk/libs/runtime_library/BUILD.gn View 1 1 chunk +53 lines, -0 lines 0 comments Download
A + webapk/libs/runtime_library/junit/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImplTest.java View 1 chunk +1 line, -1 line 0 comments Download
A + webapk/libs/runtime_library/src/README View 1 1 chunk +4 lines, -0 lines 0 comments Download
A + webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/IWebApkApi.aidl View 1 chunk +1 line, -1 line 0 comments Download
A + webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImpl.java View 1 chunk +1 line, -1 line 0 comments Download
A + webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/common.aidl View 1 1 chunk +1 line, -1 line 0 comments Download
A webapk/libs/runtime_library_version.gni View 1 1 chunk +8 lines, -0 lines 0 comments Download
A + webapk/shell_apk/AndroidManifest.xml View 2 chunks +3 lines, -3 lines 0 comments Download
A webapk/shell_apk/BUILD.gn View 1 1 chunk +89 lines, -0 lines 0 comments Download
A + webapk/shell_apk/javatests/canary_lib/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + webapk/shell_apk/javatests/canary_lib/src/org/chromium/webapk/shell_apk/test/canary/Canary.java View 1 chunk +1 line, -1 line 0 comments Download
A + webapk/shell_apk/javatests/dex_optimizer/AndroidManifest.xml View 2 chunks +2 lines, -2 lines 0 comments Download
A + webapk/shell_apk/javatests/dex_optimizer/BUILD.gn View 2 chunks +6 lines, -5 lines 0 comments Download
A + webapk/shell_apk/javatests/dex_optimizer/src/org/chromium/webapk/shell_apk/test/dex_optimizer/DexOptimizerServiceImpl.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + webapk/shell_apk/javatests/dex_optimizer/src/org/chromium/webapk/shell_apk/test/dex_optimizer/IDexOptimizerService.aidl View 1 chunk +1 line, -1 line 0 comments Download
A + webapk/shell_apk/javatests/dex_optimizer/src/org/chromium/webapk/shell_apk/test/dex_optimizer/common.aidl View 1 chunk +1 line, -1 line 0 comments Download
A + webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java View 4 chunks +7 lines, -6 lines 0 comments Download
A + webapk/shell_apk/proguard.flags View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webapk/shell_apk/res/drawable-mdpi/app_icon.png View Binary file 0 comments Download
A + webapk/shell_apk/res/layout/main.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webapk/shell_apk/src/org/chromium/webapk/shell_apk/DexLoader.java View 1 chunk +1 line, -1 line 0 comments Download
A + webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java View 3 chunks +4 lines, -5 lines 0 comments Download
A + webapk/shell_apk/src/org/chromium/webapk/shell_apk/Reflect.java View 1 chunk +1 line, -1 line 0 comments Download
A + webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkApplication.java View 1 chunk +2 lines, -2 lines 0 comments Download
A + webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkServiceFactory.java View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pkotwicz
Xi can you please take a look?
4 years, 7 months ago (2016-05-05 15:49:06 UTC) #4
Xi Han
Thanks! lgtm. https://codereview.chromium.org/1945303005/diff/20001/webapk/OWNERS File webapk/OWNERS (right): https://codereview.chromium.org/1945303005/diff/20001/webapk/OWNERS#newcode3 webapk/OWNERS:3: khushalsagar@chromium.org Sinc Khushal hasn't work on this ...
4 years, 7 months ago (2016-05-05 17:10:02 UTC) #5
Yaron
lgtm - just found one file that had a few more edits needed but ok ...
4 years, 7 months ago (2016-05-05 17:17:18 UTC) #7
Xi Han
still lgtm https://codereview.chromium.org/1945303005/diff/20001/webapk/shell_apk/BUILD.gn File webapk/shell_apk/BUILD.gn (right): https://codereview.chromium.org/1945303005/diff/20001/webapk/shell_apk/BUILD.gn#newcode25 webapk/shell_apk/BUILD.gn:25: manifest_package_minting = "org.chromium.minting" On 2016/05/05 17:17:18, Yaron ...
4 years, 7 months ago (2016-05-05 17:22:11 UTC) #8
pkotwicz
4 years, 7 months ago (2016-05-05 17:25:14 UTC) #9 
https://codereview.chromium.org/1945303005/diff/20001/webapk/shell_apk/BUILD.gn
File webapk/shell_apk/BUILD.gn (right):

https://codereview.chromium.org/1945303005/diff/20001/webapk/shell_apk/BUILD....
webapk/shell_apk/BUILD.gn:25: manifest_package_minting = "org.chromium.minting"
I should have mentioned this in the CL comments. I intentionally did not change
the name or the package of the generated APK. I will do it in a follow up CL

I will fix up comments, variable names, and function names in follow up CLs

Powered by Google App Engine
This is Rietveld 408576698