Serialize ParameterElement.node and ParameterElement.initializer for type inference

Serialize ParameterElement.node and ParameterElement.initializer for type inference

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/a5078ea5f2f45183717613c4e33dddea97958406

[Johnni Winther, 2016-05-04 13:19:39]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-05-07 01:34:35]

lgtm

https://codereview.chromium.org/1945263003/diff/20001/pkg/compiler/lib/src/se...
File pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart (right):

https://codereview.chromium.org/1945263003/diff/20001/pkg/compiler/lib/src/se...
pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart:174:
.setElement(PARAMETER_NODE, parameter);
interesting --- it feels a bit odd that our storage here is backwards (mapping
node to parameter, instead of parameter to node). Do we have anything that
supports the opposite direction (paramter -> nodeid)? Is it worth changing it?

I'm guessing this doesn't matter much since the goal is to replace this format
in the near future.

[Johnni Winther, 2016-05-09 08:18:19]

https://codereview.chromium.org/1945263003/diff/20001/pkg/compiler/lib/src/se...
File pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart (right):

https://codereview.chromium.org/1945263003/diff/20001/pkg/compiler/lib/src/se...
pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart:174:
.setElement(PARAMETER_NODE, parameter);
On 2016/05/07 01:34:35, Siggi Cherem (dart-lang) wrote:
> interesting --- it feels a bit odd that our storage here is backwards (mapping
> node to parameter, instead of parameter to node). Do we have anything that
> supports the opposite direction (paramter -> nodeid)? Is it worth changing it?
> 
> I'm guessing this doesn't matter much since the goal is to replace this format
> in the near future.

Yes, it does feel awkward to map nodes to elements here. Adding a TODO to
consider adding support for the other direction.

[Johnni Winther, 2016-05-09 08:23:39]

Description was changed from

==========
Serialize ParameterElement.node and ParameterElement.initializer for type
inference
==========

to

==========
Serialize ParameterElement.node and ParameterElement.initializer for type
inference

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a5078ea5f2f45183717613c4e33dddea97958406
==========

[Johnni Winther, 2016-05-09 08:23:41]

Committed patchset #3 (id:40001) manually as
a5078ea5f2f45183717613c4e33dddea97958406 (presubmit successful).