pkg/compiler/lib/src/serialization/modelz.dart - Issue 1945263003: Serialize ParameterElement.node and ParameterElement.initializer for type inference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/serialization/modelz.dart

Issue 1945263003: Serialize ParameterElement.node and ParameterElement.initializer for type inference (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/serialization/equivalence.dart ('k') | pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/serialization/modelz.dart

diff --git a/pkg/compiler/lib/src/serialization/modelz.dart b/pkg/compiler/lib/src/serialization/modelz.dart

index b280d6954fbccdff3f53131c1a8f6fceddca9623..7772956f1908a1a640062969081a19add626ce87 100644

--- a/pkg/compiler/lib/src/serialization/modelz.dart

+++ b/pkg/compiler/lib/src/serialization/modelz.dart

@@ -1867,13 +1867,13 @@ abstract class ParameterElementZ extends DeserializedElementZ

@override

FunctionSignature get functionSignature => _unsupported('functionSignature');

- // TODO(johnniwinther): HACK. Remove [initializer] and [node] on

+ // TODO(johnniwinther): Remove [initializer] and [node] on

// [ParameterElementZ] when the inference does need these.

@override

- Expression get initializer => null;

+ Expression initializer;

@override

- Node get node => null;

+ Node node;

@override

bool get isNamed => _decoder.getBool(Key.IS_NAMED);