Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1945173004: Fix INLINE macro on Windows (Closed)

Created:
4 years, 7 months ago by msarett
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Response to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M README.chromium View 1 1 chunk +3 lines, -0 lines 0 comments Download
M jconfigint.h View 1 chunk +7 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
msarett
I ran some trybots on the updated libjpeg-turbo roll and the Windows build is failing ...
4 years, 7 months ago (2016-05-04 20:43:08 UTC) #3
scroggo_chromium
https://codereview.chromium.org/1945173004/diff/20001/jconfigint.h File jconfigint.h (right): https://codereview.chromium.org/1945173004/diff/20001/jconfigint.h#newcode7 jconfigint.h:7: #if defined(__GNUC__) I tried to double check that this ...
4 years, 7 months ago (2016-05-04 20:56:48 UTC) #4
msarett
The original is config.h. The name was changed at some point.
4 years, 7 months ago (2016-05-04 21:00:44 UTC) #5
msarett
On 2016/05/04 21:00:44, msarett wrote: > The original is config.h. The name was changed at ...
4 years, 7 months ago (2016-05-04 21:01:30 UTC) #6
scroggo_chromium
On 2016/05/04 21:01:30, msarett wrote: > On 2016/05/04 21:00:44, msarett wrote: > > The original ...
4 years, 7 months ago (2016-05-04 21:08:07 UTC) #7
msarett
Any chromium committers able to patch and land this for me? And also https://codereview.chromium.org/1948123002? With ...
4 years, 7 months ago (2016-05-04 21:17:08 UTC) #8
Noel Gordon
Needs an entry in the chromium.README to document our changes from upstream.
4 years, 7 months ago (2016-05-05 00:26:40 UTC) #9
Noel Gordon
On 2016/05/05 00:26:40, noel gordon wrote: > Needs an entry in the chromium.README to document ...
4 years, 7 months ago (2016-05-05 00:27:10 UTC) #10
msarett
On 2016/05/05 00:26:40, noel gordon wrote: > Needs an entry in the chromium.README to document ...
4 years, 7 months ago (2016-05-05 12:59:19 UTC) #11
Noel Gordon
4 years, 7 months ago (2016-05-05 14:32:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698