Issue 1945113003: Better is/as check handling. With this CL, the subtype function in

Issue 1945113003: Better is/as check handling. With this CL, the subtype function in (Closed)

Created:
4 years, 7 months ago by Leaf

Modified:
4 years, 7 months ago

Reviewers:
vsm, Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Better is/as check handling. With this CL, the subtype function in the DDC runtime returns null when a difference from the spec mode result is possible. Fixes https://github.com/dart-lang/dev_compiler/issues/524 . BUG= R=jmesserly@google.com, vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/b318c10f309add6c643af10c0bf8ee6744f34bf8

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+363 lines, -149 lines)			Patch
M	lib/runtime/dart_sdk.js	View	1 2	9 chunks	+66 lines, -45 lines	0 comments	Download
M	test/browser/language_tests.js	View	1 2	1 chunk	+0 lines, -9 lines	0 comments	Download
M	test/browser/runtime_tests.js	View	1	11 chunks	+176 lines, -28 lines	0 comments	Download
M	test/codegen/language/type_literal_test.dart	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tool/input_sdk/private/ddc_runtime/errors.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	tool/input_sdk/private/ddc_runtime/operations.dart	View	1	3 chunks	+28 lines, -22 lines	0 comments	Download
M	tool/input_sdk/private/ddc_runtime/types.dart	View	1	11 chunks	+88 lines, -41 lines	0 comments	Download

Total messages: 7 (3 generated)

Leaf

4 years, 7 months ago (2016-05-04 20:26:02 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
b318c10f309add6c643af10c0bf8ee6744f34bf8 (presubmit successful).