tool/input_sdk/private/ddc_runtime/errors.dart - Issue 1945113003: Better is/as check handling. With this CL, the subtype function in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tool/input_sdk/private/ddc_runtime/errors.dart

Issue 1945113003: Better is/as check handling. With this CL, the subtype function in (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Update new tests after rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tool/input_sdk/private/ddc_runtime/errors.dart

diff --git a/tool/input_sdk/private/ddc_runtime/errors.dart b/tool/input_sdk/private/ddc_runtime/errors.dart

index 2225ccafdc27a391fbe39571df550977c45d5fc3..12436155ad87c3b1d496dcea2e2796455e44e3fc 100644

--- a/tool/input_sdk/private/ddc_runtime/errors.dart

+++ b/tool/input_sdk/private/ddc_runtime/errors.dart

@@ -4,7 +4,8 @@

part of dart._runtime;

throwCastError(actual, type) => JS('', '''(() => {

- $throw_(new $CastErrorImplementation($actual, $type));

+ $throw_(new $CastErrorImplementation($typeName($actual),

+ $typeName($type)));

})()''');

throwAssertionError() => JS('', '''(() => {

« no previous file with comments | « test/codegen/language/type_literal_test.dart ('k') | tool/input_sdk/private/ddc_runtime/operations.dart » ('j') | no next file with comments »