Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1944923002: Fix for Alt+Left/Right page navigation with focus on radio buttons. (Closed)

Created:
4 years, 7 months ago by Paritosh Monu
Modified:
4 years, 7 months ago
Reviewers:
tkent, bokan, dtapuska
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for Alt+Left/Right page navigation with focus on radio buttons. Added a condition for modifier state before handling keydown event. BUG=599009 Committed: https://crrev.com/336ebfae1a3dec77c73c4d545965941d935f1b99 Cr-Commit-Position: refs/heads/master@{#391621}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/forms/radio/radio-arrow-with-modifier-keys.html View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/radio/radio-arrow-with-modifier-keys-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-arrow-cycle-edge.html View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/RadioInputType.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Paritosh Monu
Hi dtapuska and tkent, Apologize for delay in response on https://codereview.chromium.org/1849273003/. This cl is the ...
4 years, 7 months ago (2016-05-03 19:47:41 UTC) #3
dtapuska
On 2016/05/03 19:47:41, Paritosh Monu wrote: > Hi dtapuska and tkent, > > Apologize for ...
4 years, 7 months ago (2016-05-03 19:57:55 UTC) #5
bokan
https://codereview.chromium.org/1944923002/diff/1/third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-arrow-cycle-edge.html File third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-arrow-cycle-edge.html (right): https://codereview.chromium.org/1944923002/diff/1/third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-arrow-cycle-edge.html#newcode22 third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-arrow-cycle-edge.html:22: description('Tests after pressing last radio button in the list, ...
4 years, 7 months ago (2016-05-03 22:13:57 UTC) #6
Paritosh Monu
On 2016/05/03 22:13:57, bokan wrote: > https://codereview.chromium.org/1944923002/diff/1/third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-arrow-cycle-edge.html > File > third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-arrow-cycle-edge.html > (right): > > ...
4 years, 7 months ago (2016-05-04 04:01:39 UTC) #7
bokan
Thanks, a few nits but once you address those, lgtm https://codereview.chromium.org/1944923002/diff/20001/third_party/WebKit/LayoutTests/fast/forms/radio/radio-arrow-with-modifier-keys.html File third_party/WebKit/LayoutTests/fast/forms/radio/radio-arrow-with-modifier-keys.html (right): https://codereview.chromium.org/1944923002/diff/20001/third_party/WebKit/LayoutTests/fast/forms/radio/radio-arrow-with-modifier-keys.html#newcode3 ...
4 years, 7 months ago (2016-05-04 12:12:13 UTC) #8
Paritosh Monu
On 2016/05/04 12:12:13, bokan wrote: > Thanks, a few nits but once you address those, ...
4 years, 7 months ago (2016-05-04 17:11:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944923002/40001
4 years, 7 months ago (2016-05-04 18:12:42 UTC) #12
commit-bot: I haz the power
The author paritosh@chromium.org has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
4 years, 7 months ago (2016-05-04 18:12:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944923002/40001
4 years, 7 months ago (2016-05-04 18:15:36 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-04 20:12:34 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 20:14:01 UTC) #20
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/336ebfae1a3dec77c73c4d545965941d935f1b99
Cr-Commit-Position: refs/heads/master@{#391621}

Powered by Google App Engine
This is Rietveld 408576698