Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: third_party/WebKit/Source/core/html/forms/RadioInputType.cpp

Issue 1944923002: Fix for Alt+Left/Right page navigation with focus on radio buttons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-arrow-cycle-edge.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/forms/RadioInputType.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/RadioInputType.cpp b/third_party/WebKit/Source/core/html/forms/RadioInputType.cpp
index 021da29c421ae1f109ce0994fa650a87472f7a8e..78532406e42ad9857016003ed2b89de17e0740b1 100644
--- a/third_party/WebKit/Source/core/html/forms/RadioInputType.cpp
+++ b/third_party/WebKit/Source/core/html/forms/RadioInputType.cpp
@@ -92,6 +92,9 @@ void RadioInputType::handleKeydownEvent(KeyboardEvent* event)
if (key != "Up" && key != "Down" && key != "Left" && key != "Right")
return;
+ if (event->ctrlKey() || event->metaKey() || event->altKey())
+ return;
+
// Left and up mean "previous radio button".
// Right and down mean "next radio button".
// Tested in WinIE, and even for RTL, left still means previous radio button
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-arrow-cycle-edge.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698