third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h - Issue 1944623002: CC Animation: Use ElementId to attach CC animation players.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h

Issue 1944623002: CC Animation: Use ElementId to attach CC animation players. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@erasedomids

Patch Set: Let CC clients generate their own ElementIds locally. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('K') | « third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp ('k') | third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h

diff --git a/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h b/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h

index 62d63d256f7118e5f483ef041eace0f10461e64a..b15d9260fbe82efa52ec29e8aff18f9c38ecfcb4 100644

--- a/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h

+++ b/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h

@@ -11,6 +11,7 @@

#include "cc/animation/animation_delegate.h"

#include "cc/animation/animation_player.h"

#include "platform/PlatformExport.h"

+#include "platform/graphics/CompositorElementId.h"

#include "wtf/Noncopyable.h"

#include <memory>

@@ -36,9 +37,9 @@ public:

// deleting the delegate.

void setAnimationDelegate(CompositorAnimationDelegate*);

- void attachLayer(WebLayer*);

- void detachLayer();

- bool isLayerAttached() const;

+ void attachElement(CompositorElementId);

+ void detachElement();

+ bool isElementAttached() const;

void addAnimation(CompositorAnimation*);

void removeAnimation(int animationId);